Migrate test app to app/ directory #1154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NSeydoux
commented
Dec 18, 2024
e2e/browser/test-app/app/layout.tsx
Outdated
There was a problem hiding this comment.
The root layout file is required.
e2e/browser/test-app/app/page.tsx
Outdated
| @@ -1,13 +1,14 @@ | |||
| 'use client'; | |||
There was a problem hiding this comment.
Pages are server components by default. We want this to be a client component because we rely on window.
e2e/browser/test-app/app/page.tsx
Outdated
Comment on lines
39
to
40
| redirectUrl: REDIRECT_URL, | ||
| redirectUrl: "http://localhost:3001", |
There was a problem hiding this comment.
Using a dynamic redirect URL was bad practice.
e2e/browser/test-app/next-env.d.ts
Outdated
There was a problem hiding this comment.
Change managed by NextJS
e2e/browser/test-app/tsconfig.json
Outdated
There was a problem hiding this comment.
Changes managed by NextJS
NSeydoux
had a problem deploying
to
ESS PodSpaces
GitHub Actions
Failure
NSeydoux
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
NSeydoux
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
NSeydoux
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
NSeydoux
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
NSeydoux
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
NSeydoux
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
NSeydoux
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
NSeydoux
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
edwardsph
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
edwardsph
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
edwardsph
temporarily deployed
to
ESS Dev-2-3
GitHub Actions
Inactive
edwardsph
temporarily deployed
to
ESS Dev-2-2
GitHub Actions
Inactive
edwardsph
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
edwardsph
had a problem deploying
to
ESS Dev-2-3
GitHub Actions
Failure
edwardsph
temporarily deployed
to
ESS Dev-2-3
GitHub Actions
Inactive
edwardsph
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
edwardsph
temporarily deployed
to
ESS Dev-2-3
GitHub Actions
Inactive
edwardsph
temporarily deployed
to
ESS Dev-2-3
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies the recommendations for the latest versions of NextJS.