Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Universal API no longer throws on missing ACL #2200

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

NSeydoux
Copy link
Contributor

@NSeydoux NSeydoux commented Sep 26, 2023

Fixes #1549

A resource having an ACL link, but this link not resolving to an ACL is a legitimate situation in the ACL protocol. The universal API had a bug that was not allowing the underlying ACL API to create the target ACL if it was missing. It is now supported.

  • I've added a unit test to test for potential regressions of this bug.
  • The changelog has been updated, if applicable.
  • Commits in this PR are minimal and have descriptive commit messages.

Fixes #1549

A resource having an ACL link, but this link not resolving to an ACL is
a legitimate situation in the ACL protocol. The universal API had a bug
that was not allowing the underlying ACL API to create the target ACL if
it was missing. It is now supported.
@vercel
Copy link

vercel bot commented Sep 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
solid-client-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2023 9:57am

@NSeydoux NSeydoux temporarily deployed to ESS PodSpaces September 26, 2023 09:56 — with GitHub Actions Inactive
@NSeydoux NSeydoux temporarily deployed to NSS September 26, 2023 09:56 — with GitHub Actions Inactive
@NSeydoux NSeydoux temporarily deployed to ESS PodSpaces September 26, 2023 09:56 — with GitHub Actions Inactive
@NSeydoux NSeydoux temporarily deployed to NSS September 26, 2023 09:56 — with GitHub Actions Inactive
@NSeydoux NSeydoux temporarily deployed to ESS PodSpaces September 26, 2023 09:56 — with GitHub Actions Inactive
@NSeydoux NSeydoux temporarily deployed to NSS September 26, 2023 09:56 — with GitHub Actions Inactive
@NSeydoux NSeydoux temporarily deployed to ESS Dev-2-2 September 26, 2023 09:56 — with GitHub Actions Inactive
@NSeydoux NSeydoux temporarily deployed to ESS PodSpaces September 26, 2023 09:56 — with GitHub Actions Inactive
@NSeydoux NSeydoux temporarily deployed to ESS PodSpaces September 26, 2023 09:56 — with GitHub Actions Inactive
@NSeydoux NSeydoux temporarily deployed to ESS Dev-2-2 September 26, 2023 09:56 — with GitHub Actions Inactive
@NSeydoux NSeydoux marked this pull request as ready for review September 26, 2023 10:04
@NSeydoux NSeydoux requested a review from a team as a code owner September 26, 2023 10:04
@NSeydoux NSeydoux merged commit 70c161d into main Sep 26, 2023
@NSeydoux NSeydoux deleted the fix/1549_support-missing-acl branch September 26, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

access/universal functions throw error instead of creating .acl when no .acl exists
2 participants