Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK-3304: Added extra node e2e tests #219

Merged
merged 14 commits into from
Aug 15, 2024
Merged

SDK-3304: Added extra node e2e tests #219

merged 14 commits into from
Aug 15, 2024

Conversation

jholleran
Copy link
Contributor

@jholleran jholleran commented Aug 13, 2024 •
edited
Loading

Problem Details e2e testing

Added Node and Browser based e2e tests for the Problem Details feature.

Checklist

  • All acceptance criteria are met.
  • Relevant documentation, if any, has been written/updated.
  • The changelog has been updated, if applicable.
  • New functions/types have been exported in index.ts, if applicable.
  • New elements of the public API have appropriate API docs (including @since and @example).
  • New modules (i.e. new .ts files) are listed in the exports field in package.json, if applicable.
  • New modules (i.e. new .ts files) are listed in the typedocOptions.entryPoints field in tsconfig.json, if applicable.
  • Commits in this PR are minimal and have descriptive commit messages.

@jholleran jholleran requested a review from a team as a code owner August 13, 2024 17:21
edwardsph
edwardsph approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@edwardsph edwardsph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but is there a reason our tests don't check the message appears in error.message?

@jholleran
Copy link
Contributor Author

I'll add that check to the tests

@jholleran jholleran marked this pull request as draft August 14, 2024 13:51
@jholleran jholleran requested review from edwardsph and a team August 15, 2024 11:03
@jholleran jholleran marked this pull request as ready for review August 15, 2024 11:04
@jholleran
Copy link
Contributor Author

@edwardsph I've made lots of changes here since your last review. Can you review it again please. Thanks.

edwardsph
edwardsph approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@edwardsph edwardsph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor text changes in comments

e2e/browser/test-app/components/problemDetails/index.tsx Outdated Show resolved Hide resolved
e2e/browser/test-app/components/problemDetails/index.tsx Outdated Show resolved Hide resolved
@jholleran jholleran enabled auto-merge (squash) August 15, 2024 16:30
@jholleran jholleran merged commit 43612d7 into main Aug 15, 2024
13 checks passed
@jholleran jholleran deleted the feature/SDK-3304-added-extra-node-e2e-tests branch August 15, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwardsph edwardsph edwardsph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jholleran @edwardsph