Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK-3304: Initial end-to-end tests #188

Merged
merged 6 commits into from
Jul 4, 2024
Merged

SDK-3304: Initial end-to-end tests #188

merged 6 commits into from
Jul 4, 2024

Conversation

NSeydoux
Copy link
Contributor

@NSeydoux NSeydoux commented Jul 3, 2024

#187 should be reviewed first.

This adds some end-to-end tests for simple use cases of the library.

@NSeydoux NSeydoux requested a review from a team as a code owner July 3, 2024 10:01
@NSeydoux NSeydoux marked this pull request as draft July 3, 2024 10:01
Base automatically changed from SDK-3306/specialized-error-classes to main July 3, 2024 13:00
NSeydoux added 3 commits July 3, 2024 15:01
This adds some end-to-end tests for simple use cases of the library.
@NSeydoux NSeydoux force-pushed the SDK-3306/e2e-tests branch from cec2bc6 to 745ca6a Compare July 3, 2024 13:02
@NSeydoux NSeydoux marked this pull request as ready for review July 3, 2024 13:06
@NSeydoux NSeydoux marked this pull request as draft July 3, 2024 13:07
@NSeydoux NSeydoux marked this pull request as ready for review July 4, 2024 08:16
Copy link
Contributor

@edwardsph edwardsph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with 1 question

e2e/env/.env.example Outdated Show resolved Hide resolved
@NSeydoux NSeydoux enabled auto-merge (squash) July 4, 2024 09:46
Copy link
Contributor

@edwardsph edwardsph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NSeydoux NSeydoux merged commit 46a08ae into main Jul 4, 2024
12 checks passed
@NSeydoux NSeydoux deleted the SDK-3306/e2e-tests branch July 4, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants