Skip to content

Commit

Permalink
SDK-3357: Add node 22 to matrix and set as default
Browse files Browse the repository at this point in the history
  • Loading branch information
edwardsph committed Aug 16, 2024
1 parent 43612d7 commit 84255e1
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 8 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
matrix:
# We test against different OSes, because the build toolchain has OS-specific dependencies.
os: ["ubuntu-latest", "windows-latest", "macos-latest"]
node-version: ["20.x", "18.x"]
node-version: ["22.x", "20.x", "18.x"]
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
Expand All @@ -30,7 +30,7 @@ jobs:
- run: npm run test
# Upload coverage for sonarcube (only matching OS and one node version required)
- uses: actions/upload-artifact@v4
if: ${{ matrix.node-version == '20.x' }}
if: ${{ matrix.node-version == '22.x' }}
with:
name: code-coverage-${{ matrix.os }}-${{matrix.node-version}}
path: coverage/
Expand All @@ -47,7 +47,7 @@ jobs:
fetch-depth: 0
- uses: actions/download-artifact@v4
with:
name: code-coverage-ubuntu-latest-20.x
name: code-coverage-ubuntu-latest-22.x
path: coverage/
- uses: SonarSource/sonarcloud-github-action@v2
env:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/e2e-node.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest]
node-version: ["20.x", "18.x"]
node-version: ["22.x", "20.x", "18.x"]
# PodSpaces doesn't support error descriptions yet.
environment-name: ["ESS Dev-2-3"]
experimental: [false]
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
20
22
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ and `String.prototype.endsWith`.
## Node.js Support

Our JavaScript Client Libraries track Node.js [LTS
releases](https://nodejs.org/en/about/releases/), and support 18.x and 20.x.
releases](https://nodejs.org/en/about/releases/), and support 18.x, 20.x, and 22.x.

# Installation

Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,6 @@
"typescript": "^5.5.4"
},
"engines": {
"node": "^18.0.0 || ^20.0.0"
"node": "^18.0.0 || ^20.0.0 || ^22.0.0"
}
}

0 comments on commit 84255e1

Please sign in to comment.