Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Pete Edwards <[email protected]>
  • Loading branch information
NSeydoux and edwardsph authored Jul 2, 2024
1 parent e81aba5 commit 32bac35
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/http/errorResponse.mock.ts
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export function mockErrorResponse({
url: url === null ? undefined : url ?? "https://example.org/resource",
headers: headers === null ? undefined : headers ?? new Headers(),
},
// The type assertion allows to create invalid error
// The type assertion allows us to create invalid error
// responses for unit tests purpose.
} as WithErrorResponse;
}
Expand Down
2 changes: 1 addition & 1 deletion src/http/problemDetails.mock.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export function mockProblemDetails({
detail,
instance,
},
// The type assertion allows to null fields for unit tests.
// The type assertion allows us to null fields for unit tests.
} as WithProblemDetails;
}

Expand Down
2 changes: 1 addition & 1 deletion src/http/problemDetails.ts
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ export type ProblemDetails = Readonly<{
*/
detail?: string;
/**
* A unique URL identifying the problem occurence.
* A unique URL identifying the problem occurrence.
*/
instance?: URL;
}>;
Expand Down

0 comments on commit 32bac35

Please sign in to comment.