Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login and Logout handler #3366

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Login and Logout handler #3366

wants to merge 10 commits into from

Conversation

zg009
Copy link

@zg009 zg009 commented Feb 22, 2024

New feature description

Addresses #422
The simplest approach was to add an entirely new EVENTS const which is simply emitted at all locations along with the login and logout existing events. I was unable to run the E2E tests, I figure it was due to the confusion on provisioning the pod base uri. I added unit tests which passed under Jest, and conformed to the existing test structure. The commit messages could be improved upon. I can create a new fork if needed.

Checklist

  • [?] All acceptance criteria are met.
  • Relevant documentation, if any, has been written/updated.
  • The changelog has been updated, if applicable.
  • New functions/types have been exported in index.ts, if applicable.
  • Commits in this PR are minimal and have descriptive commit messages.

@zg009 zg009 requested a review from a team as a code owner February 22, 2024 05:13
Copy link

vercel bot commented Feb 22, 2024

Someone is attempting to deploy a commit to the Inrupt Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@NSeydoux NSeydoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @zg009, and thanks so much for contributing! Do not worry about the end-to-end tests: once the code is in a stable state, I'll rebase your commits from your fork to a branch on the main repository, which will run all the tests. I added a couple of comments on the PR, and you can also add a changelog entry if you wish, otherwise I'll add it when rebasing. In any case, you'll be credited as a contributor to the code in the commit history, and I'll mention you in the changelog entry :)

packages/browser/src/Session.ts Outdated Show resolved Hide resolved
packages/core/src/constant.ts Outdated Show resolved Hide resolved
e2e/node/e2e-test.spec.ts Outdated Show resolved Hide resolved
@zg009
Copy link
Author

zg009 commented Apr 25, 2024

I do not know how to add a changelog entry, sorry. I am also unsure what configs are conflicting in the e2e-test file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants