Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer use a client ID for the demo #3183

Merged
merged 1 commit into from
Oct 12, 2023
Merged

No longer use a client ID for the demo #3183

merged 1 commit into from
Oct 12, 2023

Conversation

NSeydoux
Copy link
Contributor

The previously used client ID (namely https://raw.githubusercontent.com/inrupt/solid-client-authn-js/main/packages/browser/examples/single/bundle/client-app-profile.jsonld) is served with a Content-Type header set to "text/plain", which is invalid as per the specification (it is expected to be "application/ld+json"). The demo will keep an example of how a Solid-OIDC Client Id could be used, but will no longer include one.

The previously used client ID (namely https://raw.githubusercontent.com/inrupt/solid-client-authn-js/main/packages/browser/examples/single/bundle/client-app-profile.jsonld) is served with a Content-Type header set to "text/plain", which is invalid as per the specification (it is expected to be "application/ld+json"). The demo will keep an example of how a Solid-OIDC Client Id could be used, but will no longer include one.
@NSeydoux NSeydoux requested a review from a team as a code owner October 12, 2023 10:19
@NSeydoux NSeydoux merged commit 3bad925 into main Oct 12, 2023
20 checks passed
@NSeydoux NSeydoux deleted the chore/no-client-id branch October 12, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant