Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/prompt #3102

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Feat/prompt #3102

wants to merge 1 commit into from

Conversation

jaxoncreed
Copy link
Contributor

New feature description

Added the support to pass a prompt to the underlying oidc library. This was once a feature, but I think it might have been accidentally removed.

Checklist

  • All acceptance criteria are met.
  • Relevant documentation, if any, has been written/updated. (No. I don't have access to update Inrupt docs)
  • The changelog has been updated, if applicable.
  • New functions/types have been exported in index.ts, if applicable.
  • Commits in this PR are minimal and have descriptive commit messages.

Updated LoginInputOptions type to include prompt

Update changelog
@jaxoncreed jaxoncreed requested a review from a team as a code owner August 25, 2023 00:49
@NSeydoux
Copy link
Contributor

NSeydoux commented Oct 8, 2023

Hi @jaxoncreed , thanks for opening this, and i'm sorry it took me so long to respond. The prompt parameter is set by the library internally to consent for requests including the offline_access scope (which is requested by default so that the library can use the refresh token to maintain authentication), and to none for silent authentication on page reload. What is the use case for exposing this parameter through the public API?

@jaxoncreed
Copy link
Contributor Author

jaxoncreed commented Oct 17, 2023

No worries,

This would allow you to use the create prompt for servers that support it (https://openid.net/specs/openid-connect-prompt-create-1_0.html). Alternatively, we could have a separate function for create, but that might be confusing because not all Solid Servers support the create prompt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants