-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: hoist devDependencies and migrate to workspaces + rollup #2097
base: main
Are you sure you want to change the base?
Conversation
We were accidentally importing stuff across module boundaries and also importing types without the 'type' keyword on the import
] | ||
"webpack": "^5.11.0", | ||
"webpack-cli": "^4.2.0", | ||
"webpack-merge": "^5.7.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Webpack is only used for the example apps now, but we can and probably should migrate to something else there (swc, next, rollup, etc)
}, | ||
"overrides": { | ||
"@inrupt/[email protected]": { | ||
"eslint-plugin-jest": "^26.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is needed until we publish @inrupt/[email protected]
, as v0.4.0
/ v0.4.1
do not use Jest 27
"license": "MIT", | ||
"types": "dist/index", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pretty sure this was a bug
@NSeydoux let's figure out a plan for the work that's been done here, most is already done elsewhere now, so really there's just the webpack -> rollup migration left. |
This is a highly experimental branch, where in I'm attempting to address some long standing issues with how we build the code in this repo. The commits are not minimal, there's a lot of cruft that needs to be cleaned up, but it's a first working version.
One note for Next.js: If you're using
@inrupt/solid-ui-react
and encounter an error when loading the SessionProvider (or other components), and the error is about window being undefined, well, it turns out that's kinda a next.js quirk that webpack was silently allowing to work somehow. We do need to "fix" the SDK to not make direct use of thewindow
global object, but that's additional work that I'm trying to keep out of scope.If you wanna test in next.js you'll need to do the following instead of just
import { SessionProvider } from "@inrupt/solid-ui-react"
:Additionally, there's some package json changes needed to properly tie it all together: