-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add restrictions on Access Crendentials queries #1201
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Queries must now be on Access Grants or Access Requests, rather than generically on Acces Credentials. This is aligned with the JCL general behavior.
NSeydoux
temporarily deployed
to
ESS PodSpaces
December 22, 2024 23:00 — with
GitHub Actions
Inactive
NSeydoux
temporarily deployed
to
ESS PodSpaces
December 22, 2024 23:00 — with
GitHub Actions
Inactive
NSeydoux
temporarily deployed
to
ESS PodSpaces
December 22, 2024 23:00 — with
GitHub Actions
Inactive
NSeydoux
temporarily deployed
to
ESS PodSpaces
December 22, 2024 23:00 — with
GitHub Actions
Inactive
edwardsph
approved these changes
Dec 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
edwardsph
temporarily deployed
to
ESS PodSpaces
December 23, 2024 15:58 — with
GitHub Actions
Inactive
edwardsph
temporarily deployed
to
ESS PodSpaces
December 23, 2024 15:58 — with
GitHub Actions
Inactive
edwardsph
temporarily deployed
to
ESS Dev-2-2
December 23, 2024 15:58 — with
GitHub Actions
Inactive
edwardsph
temporarily deployed
to
ESS Dev-2-2
December 23, 2024 15:58 — with
GitHub Actions
Inactive
edwardsph
temporarily deployed
to
ESS Dev-2-3
December 23, 2024 15:58 — with
GitHub Actions
Inactive
edwardsph
temporarily deployed
to
ESS PodSpaces
December 23, 2024 15:58 — with
GitHub Actions
Inactive
edwardsph
temporarily deployed
to
ESS Dev-2-2
December 23, 2024 15:58 — with
GitHub Actions
Inactive
edwardsph
temporarily deployed
to
ESS PodSpaces
December 23, 2024 15:58 — with
GitHub Actions
Inactive
edwardsph
temporarily deployed
to
ESS Dev-2-2
December 23, 2024 15:58 — with
GitHub Actions
Inactive
edwardsph
temporarily deployed
to
ESS Dev-2-3
December 23, 2024 15:58 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Queries must now be on Access Grants or Access Requests, rather than generically on Acces Credentials. This is aligned with the JCL general behavior.
This also enforces URL objects are used rather than string, which is more consistent with the rest of the API (in particular, URL are used in custom fields already.