Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add restrictions on Access Crendentials queries #1201

Merged
merged 3 commits into from
Dec 23, 2024

Conversation

NSeydoux
Copy link
Contributor

Queries must now be on Access Grants or Access Requests, rather than generically on Acces Credentials. This is aligned with the JCL general behavior.

This also enforces URL objects are used rather than string, which is more consistent with the rest of the API (in particular, URL are used in custom fields already.

Queries must now be on Access Grants or Access Requests, rather than
generically on Acces Credentials. This is aligned with the JCL general
behavior.
@NSeydoux NSeydoux requested a review from a team as a code owner December 22, 2024 22:59
Copy link
Contributor

@edwardsph edwardsph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/gConsent/query/query.ts Outdated Show resolved Hide resolved
@NSeydoux NSeydoux merged commit f7d24a6 into main Dec 23, 2024
26 checks passed
@NSeydoux NSeydoux deleted the feat/SDK-3376/access-grant-queries-fixup branch December 23, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants