Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw custom error #1190

Merged
merged 7 commits into from
Dec 13, 2024
Merged

Throw custom error #1190

merged 7 commits into from
Dec 13, 2024

Conversation

NSeydoux
Copy link
Contributor

This makes it so that the library throws a custom AccessGrantError (or UmaError, extending the shared InruptClientError instead of a generic Error.

@NSeydoux NSeydoux requested a review from a team as a code owner December 13, 2024 11:07
@NSeydoux NSeydoux force-pushed the feat/SDK-3382/error-management branch from be8e637 to 12f4c42 Compare December 13, 2024 12:52
@edwardsph edwardsph enabled auto-merge (squash) December 13, 2024 16:29
edwardsph
edwardsph approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@edwardsph edwardsph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edwardsph edwardsph merged commit c9536f2 into main Dec 13, 2024
26 checks passed
@edwardsph edwardsph deleted the feat/SDK-3382/error-management branch December 13, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwardsph edwardsph edwardsph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NSeydoux @edwardsph