Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get custom fields #1178

Merged
merged 34 commits into from
Dec 12, 2024
Merged

Get custom fields #1178

merged 34 commits into from
Dec 12, 2024

Conversation

NSeydoux
Copy link
Contributor

@NSeydoux NSeydoux commented Dec 9, 2024

Refines getters to read custom fields.

This adds throwing on deserialization issues or unexpected number of values as well.

Supporting arrays is out of scope for this.

Checklist

  • All acceptance criteria are met.
  • Relevant documentation, if any, has been written/updated.
  • The changelog has been updated, if applicable.
  • New functions/types have been exported in index.ts, if applicable.
  • New modules (i.e. new .ts files) are listed in the exports field in package.json, if applicable.
  • New modules (i.e. new .ts files) are listed in the typedocOptions.entryPoints field in tsconfig.json, if applicable.
  • Commits in this PR are minimal and have descriptive commit messages.

@NSeydoux NSeydoux force-pushed the feat/SDK-3382/get-custom-fields branch from e641019 to ace91b1 Compare December 9, 2024 09:54
@NSeydoux NSeydoux force-pushed the feat/SDK-3382/write-custom-fields branch from 1b29687 to 74253e0 Compare December 9, 2024 09:55
@NSeydoux NSeydoux force-pushed the feat/SDK-3382/get-custom-fields branch from 07e4429 to d94f7ad Compare December 9, 2024 15:57
Copy link
Contributor

@edwardsph edwardsph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NSeydoux NSeydoux enabled auto-merge (squash) December 12, 2024 12:50
@NSeydoux NSeydoux merged commit 58b164c into main Dec 12, 2024
26 checks passed
@NSeydoux NSeydoux deleted the feat/SDK-3382/get-custom-fields branch December 12, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants