-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get custom fields #1178
Merged
Merged
Get custom fields #1178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NSeydoux
force-pushed
the
feat/SDK-3382/get-custom-fields
branch
from
December 9, 2024 09:54
e641019
to
ace91b1
Compare
NSeydoux
had a problem deploying
to
ESS PodSpaces
December 9, 2024 09:54 — with
GitHub Actions
Failure
NSeydoux
had a problem deploying
to
ESS Dev-2-2
December 9, 2024 09:54 — with
GitHub Actions
Failure
NSeydoux
had a problem deploying
to
ESS PodSpaces
December 9, 2024 09:54 — with
GitHub Actions
Failure
NSeydoux
had a problem deploying
to
ESS Dev-2-2
December 9, 2024 09:54 — with
GitHub Actions
Failure
NSeydoux
had a problem deploying
to
ESS Dev-2-3
December 9, 2024 09:54 — with
GitHub Actions
Failure
NSeydoux
had a problem deploying
to
ESS PodSpaces
December 9, 2024 09:54 — with
GitHub Actions
Failure
NSeydoux
had a problem deploying
to
ESS Dev-2-2
December 9, 2024 09:54 — with
GitHub Actions
Failure
NSeydoux
had a problem deploying
to
ESS PodSpaces
December 9, 2024 09:54 — with
GitHub Actions
Failure
NSeydoux
force-pushed
the
feat/SDK-3382/write-custom-fields
branch
from
December 9, 2024 09:55
1b29687
to
74253e0
Compare
NSeydoux
had a problem deploying
to
ESS PodSpaces
December 9, 2024 09:57 — with
GitHub Actions
Failure
NSeydoux
had a problem deploying
to
ESS PodSpaces
December 9, 2024 09:57 — with
GitHub Actions
Failure
NSeydoux
had a problem deploying
to
ESS Dev-2-2
December 9, 2024 09:57 — with
GitHub Actions
Failure
NSeydoux
had a problem deploying
to
ESS Dev-2-2
December 9, 2024 09:57 — with
GitHub Actions
Failure
NSeydoux
had a problem deploying
to
ESS Dev-2-3
December 9, 2024 09:57 — with
GitHub Actions
Failure
NSeydoux
had a problem deploying
to
ESS PodSpaces
December 9, 2024 09:57 — with
GitHub Actions
Failure
NSeydoux
had a problem deploying
to
ESS Dev-2-2
December 9, 2024 09:57 — with
GitHub Actions
Failure
NSeydoux
had a problem deploying
to
ESS PodSpaces
December 9, 2024 09:57 — with
GitHub Actions
Error
NSeydoux
had a problem deploying
to
ESS Dev-2-3
December 9, 2024 09:57 — with
GitHub Actions
Failure
5 tasks
NSeydoux
force-pushed
the
feat/SDK-3382/get-custom-fields
branch
from
December 9, 2024 15:57
07e4429
to
d94f7ad
Compare
NSeydoux
had a problem deploying
to
ESS PodSpaces
December 9, 2024 15:57 — with
GitHub Actions
Failure
NSeydoux
had a problem deploying
to
ESS PodSpaces
December 9, 2024 15:57 — with
GitHub Actions
Failure
NSeydoux
had a problem deploying
to
ESS PodSpaces
December 9, 2024 15:57 — with
GitHub Actions
Error
Co-authored-by: Pete Edwards <[email protected]>
NSeydoux
force-pushed
the
feat/SDK-3382/get-custom-fields
branch
from
December 12, 2024 11:02
e059ce1
to
c5da405
Compare
NSeydoux
temporarily deployed
to
ESS PodSpaces
December 12, 2024 11:02 — with
GitHub Actions
Inactive
NSeydoux
had a problem deploying
to
ESS Dev-2-2
December 12, 2024 11:02 — with
GitHub Actions
Failure
NSeydoux
temporarily deployed
to
ESS PodSpaces
December 12, 2024 11:03 — with
GitHub Actions
Inactive
NSeydoux
temporarily deployed
to
ESS PodSpaces
December 12, 2024 11:03 — with
GitHub Actions
Inactive
NSeydoux
temporarily deployed
to
ESS PodSpaces
December 12, 2024 11:03 — with
GitHub Actions
Inactive
edwardsph
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refines getters to read custom fields.
This adds throwing on deserialization issues or unexpected number of values as well.
Supporting arrays is out of scope for this.
Checklist
index.ts
, if applicable..ts
files) are listed in theexports
field inpackage.json
, if applicable..ts
files) are listed in thetypedocOptions.entryPoints
field intsconfig.json
, if applicable.