Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Pete Edwards <[email protected]>
  • Loading branch information
NSeydoux and edwardsph authored Dec 19, 2024
1 parent 7d323f9 commit e32a4f4
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ This project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html
The following changes are pending, and will be applied on the next major release:

- The `getAccessGrantAll` function is deprecated. It can be replaced with `query`.
Although the two functions behavior is different, they can be used to achieve
Although the two functions' behavior is different, they can be used to achieve
similar results.
- The `gConsent` and all of `gConsent/*` submodules are deprecated. The former can
be replaced by a regular import of the library, and the latter can be replaced
Expand Down
6 changes: 3 additions & 3 deletions src/gConsent/query/query.ts
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ function toCredentialFilter(url: URL): CredentialFilter {
async function parseQueryResponse(
responseJson: unknown,
): Promise<DatasetWithId[]> {
// The type assertion here is immediatly checked.
// The type assertion here is immediately checked.
const candidate = responseJson as { items: unknown };
if (candidate.items === undefined || !Array.isArray(candidate.items)) {
throw new AccessGrantError(
Expand Down Expand Up @@ -216,11 +216,11 @@ function toQueryUrl(endpoint: URL, filter: CredentialFilter): URL {
}

/**
* Query for Access Credential (Access Requests, Access Grants or Access Denials) based on a given filter.
* Query for Access Credentials (Access Requests, Access Grants or Access Denials) based on a given filter.
*
* @param filter The query filter
* @param options Query options
* @returns a paginated set of matching the given filter
* @returns a paginated set of Access Credentials matching the given filter
* @since unreleased
*
* @example
Expand Down

0 comments on commit e32a4f4

Please sign in to comment.