Apply suggestions from code review

Co-authored-by: Pete Edwards <[email protected]>

CHANGELOG.md

@@ -18,7 +18,7 @@ The following changes are pending, and will be applied on the next major release
   custom fields, and via a set of dedicated getters in the `getters/` module. A generic getter
   is introduced, `getCustomFields`, as well as a set of typed helpers, such as `getCustomInteger`
   and `getCustomIntegers`. Typed helpers are available for integers, floats, strings and booleans,
-  with a scalar and array value for each.
+  with a scalar and array version of each.
 
 ## [3.1.1](https://github.com/inrupt/solid-client-access-grants-js/releases/tag/v3.1.1) - 2024-10-23
 

src/common/getters.ts

@@ -518,8 +518,8 @@ export function getCustomFields(
 
 /**
  * Internal function. Deserializes a literal using the provided function.
- * If the literal cannot be deserialized as expected (e.g. a string attempted
- * to be deserialized as an integer), an error is thrown.
+ * If the literal cannot be deserialized as expected (e.g. an attempt to
+ * deserialize a string as an integer), an error is thrown.
  *
  * @hidden
  */
@@ -578,7 +578,7 @@ function deserializeField<T>(
  *   ]),
  * });
  * // s is [true, false, true]
- * const s = getCustomBoolean(accessRequest, new URL("https://example.org/ns/customBoolean"));
+ * const s = getCustomBooleans(accessRequest, new URL("https://example.org/ns/customBoolean"));
  * ```
  *
  * @param accessCredential The Access Credential (Access Grant or Access Request)
@@ -753,7 +753,7 @@ export function getCustomIntegers(
  *   ]),
  * });
  * // i is 1
- * const i = getCustomString(accessRequest, new URL("https://example.org/ns/customInteger"));
+ * const i = getCustomInteger(accessRequest, new URL("https://example.org/ns/customInteger"));
  * ```
  *
  * @param accessCredential The Access Credential (Access Grant or Access Request)
@@ -795,8 +795,13 @@ export function getCustomInteger(
  * @returns the custom string array field with the provided name
  * @since unreleased
  */
-export function getCustomStrings(vc: DatasetWithId, field: URL): string[] {
-  return deserializeFields(vc, field, (s) => typeof s === "string", "string");
+export function getCustomStrings(accessCredential: DatasetWithId, field: URL): string[] {
+  return deserializeFields(
+    accessCredential,
+    field,
+    (s) => typeof s === "string",
+    "string",
+  );  
 }
 
 /**

src/type/CustomField.ts

@@ -84,10 +84,10 @@ export const toJson = (
                 // Append the new value to the existing array.
                 [`${curKey}`]: [...acc[curKey], cur[curKey]],
                 // TS is rightfully upset here, because we're pretending
-                // all the values for a given key is of the same type,
+                // all the values for a given key are of the same type,
                 // which is not enforced at write time. Typed helpers
-                // will throw at read time, but untyped reader will allow
-                // to read back whathever.
+                // will throw at read time, but untyped readers will allow
+                // anything to be read back.
               } as Record<string, CustomField["value"]>;
             }
             return {