Skip to content

Commit

Permalink
SDK-3286: Pin playwright and re-enable webkit tests (#965)
Browse files Browse the repository at this point in the history
* SDK-3286: Pin playwright/test to ~1.37.0

* SDK-3286: Re-enable WebKit tests
  • Loading branch information
RWJMurphy authored Apr 10, 2024
1 parent 8f68288 commit 1f1f1a6
Show file tree
Hide file tree
Showing 3 changed files with 36 additions and 51 deletions.
66 changes: 26 additions & 40 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@
"@inrupt/jest-jsdom-polyfills": "^3.0.2",
"@inrupt/solid-client-authn-browser": "^2.0.0",
"@inrupt/solid-client-authn-node": "^2.0.0",
"@playwright/test": "^1.40.1",
"@playwright/test": "~1.37.0",
"@rdfjs/types": "^1.1.0",
"@rushstack/eslint-patch": "^1.6.1",
"@types/auth-header": "^1.0.6",
Expand Down
19 changes: 9 additions & 10 deletions playwright.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -59,16 +59,15 @@ const config: PlaywrightTestConfig = {
}. Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.103 Safari/537.36`,
},
},
// SDK-3286: Re-enable webkit test after figuring out playwright flakyness.
// {
// name: "WebKit",
// use: {
// browserName: "webkit",
// userAgent: `Browser-based solid-client-access-grant end-to-end tests running ${
// process.env.CI === "true" ? "in CI" : "locally"
// }. Mozilla/5.0 (iPhone; CPU iPhone OS 13_5_1 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/13.1.1 Mobile/15E148 Safari/604.1`,
// },
// },
{
name: "WebKit",
use: {
browserName: "webkit",
userAgent: `Browser-based solid-client-access-grant end-to-end tests running ${
process.env.CI === "true" ? "in CI" : "locally"
}. Mozilla/5.0 (iPhone; CPU iPhone OS 13_5_1 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/13.1.1 Mobile/15E148 Safari/604.1`,
},
},
],
};

Expand Down

0 comments on commit 1f1f1a6

Please sign in to comment.