Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WALLET-573 : Fix issues when upload file #69

Merged
merged 4 commits into from
Sep 23, 2024
Merged

Conversation

quanvo298Wizeline
Copy link
Contributor

@quanvo298Wizeline quanvo298Wizeline requested review from a team as code owners September 23, 2024 10:11
@quanvo298Wizeline quanvo298Wizeline changed the title Fix issue and increase some dependiences WALLET-573 : Fix issues when upload file Sep 23, 2024
hasProblemDetails(error) &&
error.problemDetails.status === NOT_ACCEPTABLE_STATUS
) {
// This is the expected behavior of the Solid server. The file has already been uploaded to Solid, even though the server returned a 406 error.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know why this happens - something must be trying to upload the file a second time which seems odd.

@edwardsph edwardsph enabled auto-merge (squash) September 23, 2024 14:24
Copy link
Contributor

@edwardsph edwardsph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change for WALLET-539 has been removed for now as it has wider implications.

@edwardsph edwardsph merged commit 9f7c7fb into main Sep 23, 2024
4 checks passed
@edwardsph edwardsph deleted the fix/WALLET-573-FileStorage branch September 23, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants