Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/wallet 486 login #66

Merged
merged 7 commits into from
Sep 19, 2024
Merged

Fix/wallet 486 login #66

merged 7 commits into from
Sep 19, 2024

Conversation

quanvo298Wizeline
Copy link
Contributor

  • The issue occurred because the useQuery hook was running a fetch request before the WebView was ready after the app moved from inactive to active. As a result, cookies were not available for the fetch request, causing a 401 error. I moved the useQuery API call to a useEffect hook to ensure that all components are rendered before the fetch occurs.
  • Show ActivityIndicator while login page is loading in Webview
RPReplay_Final1726653902.MP4

app/(tabs)/accesses/index.test.tsx Outdated Show resolved Hide resolved
components/login/LoginWebViewModal.tsx Outdated Show resolved Hide resolved
components/login/LoginWebViewModal.tsx Outdated Show resolved Hide resolved
app/index.tsx Outdated Show resolved Hide resolved
app/login.tsx Outdated Show resolved Hide resolved
@NSeydoux NSeydoux merged commit 129b215 into main Sep 19, 2024
4 checks passed
@NSeydoux NSeydoux deleted the fix/WALLET-486-Login branch September 19, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants