Fix/wallet 424 wallet login #39
Conversation
quanvo298Wizeline
commented
Sep 5, 2024
•
quanvo298Wizeline
commented
- The react-native-webview-ios-cache-clear library is not supported on Expo Go, so I used the official function from "react-native/Libraries/Network/RCTNetworking" to clear network cookies.
- Additionally, I implemented a "sign-out request" in the WebView for logging out. This clears cookies via the response from the request instead of calling the logout API.
- I created the useInruptLogin hook and the LoginWebViewModal component to make the code cleaner and more readable, and to ensure that the WebView clears its cache when closed or logged out.
…al to make WebView do not unmounted when modal closed
…al to make WebView do not unmounted when modal closed
…al to make WebView do not unmounted when modal closed
metro.config.js
Outdated
| @@ -29,6 +30,7 @@ module.exports = (() => { | |||
| ...resolver, | |||
| assetExts: resolver.assetExts.filter((ext) => ext !== "svg"), | |||
| sourceExts: [...resolver.sourceExts, "svg"], | |||
| blacklistRE: exclusionList([/.*\.test\.tsx$/]), | |||
There was a problem hiding this comment.
Is this blacklist made redundant by #38?
There was a problem hiding this comment.
Actually no, my fix apparently didn't fix the issue (I apparently didn't re-generate the android folder enough)
There was a problem hiding this comment.
#38 PR do not fix issue what I am facing when build code from latest code. This config are to fix issue as attachments:
There was a problem hiding this comment.
You're correct, I've applied your fix in #43.
…al to make WebView do not unmounted when modal closed
…al to make WebView do not unmounted when modal closed
…al to make WebView do not unmounted when modal closed
NSeydoux
force-pushed
the
fix/WALLET-424-Wallet-Login
branch
from
0128eed to
85004e9
Compare
|
This looks good, but can you adress the React warning on the incomplete dependency array for I would have expected this to fail linting, can you have a look into why it didn't? |
Fixed by useCallback and add requestLogout to deps Array |
|
Did you find why the linter didn't report these issues? |
I tried run lint on my local then it throws warning: |
