-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WALLET-396: Update dependencies #21
Conversation
components/files/VcCard.tsx
Outdated
typeof subject[1] === "string" || typeof subject[1] === "number" | ||
? (subject[1] as string) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems wrong. Essentially, I understand it as "if it's a string or a number, act as if it were a string" rather than actually converting the number into a string (e.g. using Number
and toString
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is toString()
for both cases good enough or do we need to handle the 3 cases of string, number, other more explicitly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Primitive types don't have a toString
method, so I don't think that can work, they'd have to be converted to an object first. I added a suggestion to that end.
8f69a7d
to
5ea30eb
Compare
Co-authored-by: Zwifi <[email protected]>
android/
folder to.gitignore
router.d.ts
and cause a TS warning when using a route as apathname
inFileList.tsx