Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WALLET-396: Update dependencies #21

Merged
merged 7 commits into from
Aug 12, 2024
Merged

Conversation

edwardsph
Copy link
Contributor

  • Add all of android/ folder to .gitignore
  • Fix VC card display to show membership or student number when encoded as a number rather than as a string
  • Update all dependencies where possible. There were 3 exceptions:
    • expo-router - stopped at 3.5.17 as later versions change the generated router.d.ts and cause a TS warning when using a route as a pathname in FileList.tsx
    • react-native-reanimated - stopped at 3.10.1 as later versions complain of a mismatch in JS versions
    • react-native-webview - stopped at 13.10.4 as later versions cause an error saying the native WebView is missing

@edwardsph edwardsph requested review from a team as code owners August 8, 2024 15:42
@edwardsph edwardsph enabled auto-merge (squash) August 9, 2024 09:28
Comment on lines 49 to 50
typeof subject[1] === "string" || typeof subject[1] === "number"
? (subject[1] as string)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems wrong. Essentially, I understand it as "if it's a string or a number, act as if it were a string" rather than actually converting the number into a string (e.g. using Number and toString)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is toString() for both cases good enough or do we need to handle the 3 cases of string, number, other more explicitly?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Primitive types don't have a toString method, so I don't think that can work, they'd have to be converted to an object first. I added a suggestion to that end.

@edwardsph edwardsph force-pushed the wallet-396-update-dependencies branch from 8f69a7d to 5ea30eb Compare August 9, 2024 12:07
components/files/VcCard.tsx Outdated Show resolved Hide resolved
@edwardsph edwardsph merged commit a578fd7 into main Aug 12, 2024
7 checks passed
@edwardsph edwardsph deleted the wallet-396-update-dependencies branch August 12, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants