WALLET-412: Run UI-based tests in CI #20
Conversation
NSeydoux
force-pushed
the
chore/WALLET-412/detox-in-ci
branch
from
730b426 to
86cda4e
Compare
|
The tests run correctly on my local machine, but the app crashes when I try running it in Docker. |
|
This is ready for review, as it adds a couple of changes that are desirable:
However, the main point of this work was to enable UI tests in CI, or at least in Docker, and that didn't work out. |
.detoxrc.js
Outdated
| artifacts: { | ||
| rootDir: process.env.NODE_ENV === "docker" ? "/screenshots/" : "./screenshots/", | ||
| plugins: { | ||
| log: {"enabled": true}, | ||
| uiHierarchy: {"enabled": true}, | ||
| screenshot: { | ||
| keepOnlyFailedTestsArtifacts: false, | ||
| takeWhen: { | ||
| "testStart": true, | ||
| "testDone": true | ||
| } | ||
| }, | ||
| video: { | ||
| enabled: true | ||
| } | ||
| } |
There was a problem hiding this comment.
This adds more output to the UI-based tests, which is useful for debug purpose even outside of CI.
Dockerfile
Outdated
There was a problem hiding this comment.
This Dockerfile is a basis, but it currently does not run the UI-based tests successfully. Arguably, this could be removed from the repo altogether, but some of the work that went in running the emulator in the container is good to keep around I would say.
android-config/signing-config.gradle
Outdated
There was a problem hiding this comment.
This change aligns the naming convention with the gradle typical system properties.
| await this.signInFormUsernameInput.runScript(`(element) => { | ||
| element.value = "${username}"; | ||
| }`); | ||
| await this.signInFormUsernameInput.replaceText(username); |
There was a problem hiding this comment.
This feels like a more readable approach, using a more appropriate API for the task.
| }); | ||
|
|
||
| await expect(this.signInSubmitButton).toExist(); | ||
| await this.signInSubmitButton.tap(); |
There was a problem hiding this comment.
Ditto using a more expressive API for the given task.
| by.web.xpath('//button[text()="Continue"]') | ||
| by.web.cssSelector('button[data-testid="prompt-continue"]') |
There was a problem hiding this comment.
Using data-testid attributes, meant for automated tests and more stable than text content, is a good practice.
plugins/withSigningConfig.js
Outdated
There was a problem hiding this comment.
This change moves the signing configuration out of the global gradle config into the environment, which is easier to integrate in CI/CD and is a more appropriate scope.
run_docker_ui_tests.sh
Outdated
There was a problem hiding this comment.
Same as the Dockerfile, useful findings but currently not working as desired.
This is an initial test to see if hardware acceleration works in CI
Previously, the keystore configuration was stored in the global gradle configuration, which is fine for dev machines, but more problematic for CI. Keystore configuration now comes from environment variables, which is easier to manipulate in CI.
HW acceleration is available in the CI runner.
This doesn't work, so we aren't pursuing this approach for the time being.
NSeydoux
force-pushed
the
chore/WALLET-412/detox-in-ci
branch
from
132293d to
e235929
Compare
This adds the setup required to run the Detox UI-based tests in CI: