Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WALLET-383: Fix security vulnerabilities in android manifest #11

Merged
merged 4 commits into from
Aug 2, 2024

Conversation

NSeydoux
Copy link
Contributor

@NSeydoux NSeydoux commented Aug 1, 2024

This fixes a handful of vulnerabilities from the android manifest:

  • No http communication allowed
  • No external storage read/write
  • No audio recording
  • No application data backup

None of these are required for the app to achieve its purpose.

`usesCleartextTraffic` should be set to false by default. It is
overriden to `true` in the debug build to support local development.
@NSeydoux NSeydoux requested review from a team as code owners August 1, 2024 22:09
Copy link
Contributor

@edwardsph edwardsph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NSeydoux NSeydoux merged commit 85a5b6f into main Aug 2, 2024
7 checks passed
@NSeydoux NSeydoux deleted the fix/WALLET-383/useClearText-false branch August 2, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants