Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grant access to non-existing resource #85

Merged
merged 6 commits into from
Jul 1, 2024

Conversation

garciafdezpatricia
Copy link
Contributor

@garciafdezpatricia garciafdezpatricia commented Jun 26, 2024

Fix: granting access to non-existing resources

Description of changes

AMC was previously attempting to update the resource’s ACR when approving an access request. This is the default behaviour for approveAccessRequest if no value for the updateAcr option is present. This fix defaults updating the ACR to false.

Since ESS 2.1, the ACRs are initialised to allow Access Grants by default. However, for legacy Pods provisioned before that, we still need a control to update the ACR. This is introduced by adding a checkbox in the approval of the access request.

In the case of trying to issue an Access Grant for a resource that doesn’t exist and that is on a Pod provisioned before 2.1, the respective error message will be explained to the user.

User testing instructions

Commit checklist

  • All acceptance criteria are met.
  • Includes tests to ensure functionality, accessibility and prevent regressions, including E2E tests for supported browsers.
  • Relevant documentation, if any, has been written/updated.
  • The changelog has been updated, if applicable.
  • A changeset version has been created, if applicable.
  • Meets Inrupt coding standards and adheres to commit conventions.

Design requirements checklist

  • Meets Inrupt API Design and UX standards
  • Is responsive to our documented minimum supported screen size + resolution
  • Code is extensible by external contributors or anyone forking

Copy link

vercel bot commented Jun 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
authorization-management-component ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 1, 2024 7:26pm

@garciafdezpatricia garciafdezpatricia marked this pull request as ready for review June 27, 2024 11:37
@garciafdezpatricia garciafdezpatricia requested a review from a team as a code owner June 27, 2024 11:37
@garciafdezpatricia
Copy link
Contributor Author

Note: #86 should be reviewed and merged before this one

@acoburn acoburn temporarily deployed to ESS PodSpaces July 1, 2024 19:25 — with GitHub Actions Inactive
@garciafdezpatricia garciafdezpatricia merged commit fa3f8ae into main Jul 1, 2024
9 checks passed
@garciafdezpatricia garciafdezpatricia deleted the fix/grant-access-non-existing-resource branch July 1, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants