-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grant access to non-existing resource #85
Merged
garciafdezpatricia
merged 6 commits into
main
from
fix/grant-access-non-existing-resource
Jul 1, 2024
Merged
Grant access to non-existing resource #85
garciafdezpatricia
merged 6 commits into
main
from
fix/grant-access-non-existing-resource
Jul 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
garciafdezpatricia
had a problem deploying
to
ESS PodSpaces
June 26, 2024 14:40 — with
GitHub Actions
Failure
garciafdezpatricia
had a problem deploying
to
ESS Dev-2-2
June 26, 2024 14:40 — with
GitHub Actions
Failure
garciafdezpatricia
had a problem deploying
to
ESS PodSpaces
June 26, 2024 14:53 — with
GitHub Actions
Failure
garciafdezpatricia
had a problem deploying
to
ESS Dev-2-2
June 26, 2024 14:53 — with
GitHub Actions
Failure
garciafdezpatricia
had a problem deploying
to
ESS PodSpaces
June 26, 2024 14:55 — with
GitHub Actions
Failure
garciafdezpatricia
had a problem deploying
to
ESS Dev-2-2
June 26, 2024 14:55 — with
GitHub Actions
Failure
garciafdezpatricia
had a problem deploying
to
ESS PodSpaces
June 27, 2024 11:25 — with
GitHub Actions
Failure
garciafdezpatricia
had a problem deploying
to
ESS Dev-2-2
June 27, 2024 11:25 — with
GitHub Actions
Failure
garciafdezpatricia
had a problem deploying
to
ESS PodSpaces
June 28, 2024 13:17 — with
GitHub Actions
Error
garciafdezpatricia
had a problem deploying
to
ESS Dev-2-2
June 28, 2024 13:17 — with
GitHub Actions
Error
garciafdezpatricia
had a problem deploying
to
ESS PodSpaces
June 28, 2024 13:23 — with
GitHub Actions
Failure
garciafdezpatricia
had a problem deploying
to
ESS Dev-2-2
June 28, 2024 13:23 — with
GitHub Actions
Error
garciafdezpatricia
force-pushed
the
fix/grant-access-non-existing-resource
branch
from
June 28, 2024 13:27
3f5c79d
to
53bcb59
Compare
garciafdezpatricia
had a problem deploying
to
ESS PodSpaces
June 28, 2024 13:27 — with
GitHub Actions
Failure
garciafdezpatricia
had a problem deploying
to
ESS Dev-2-2
June 28, 2024 13:27 — with
GitHub Actions
Failure
Note: #86 should be reviewed and merged before this one |
acoburn
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: granting access to non-existing resources
Description of changes
AMC was previously attempting to update the resource’s ACR when approving an access request. This is the default behaviour for
approveAccessRequest
if no value for theupdateAcr
option is present. This fix defaults updating the ACR to false.Since ESS 2.1, the ACRs are initialised to allow Access Grants by default. However, for legacy Pods provisioned before that, we still need a control to update the ACR. This is introduced by adding a checkbox in the approval of the access request.
In the case of trying to issue an Access Grant for a resource that doesn’t exist and that is on a Pod provisioned before 2.1, the respective error message will be explained to the user.
User testing instructions
Commit checklist
Design requirements checklist