fix: logout from both idp and app #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
NSeydoux
reviewed
Jun 7, 2024
src/components/Header/Header.tsx
Outdated
Comment on lines
37
to
46
| const isUrl = (candidateUrl: string | URL) => { | ||
| try { | ||
| // If url is not URL-shaped, this will throw. | ||
| // eslint-disable-next-line no-new | ||
| new URL(candidateUrl); | ||
| return true; | ||
| } catch (_e) { | ||
| return false; | ||
| } | ||
| }; |
There was a problem hiding this comment.
Can you try removing this, and using a call to URL.canParse instead? It's a fairly recent addition to browsers, but I think because we are transpiling the code targeting an older EcmaScript version we should be good there and not become unaccessible for older browsers.
There was a problem hiding this comment.
I'm not having any problems locally either when running the tests nor the app itself, but URL.canParse is causing some failures on the Vercel deployment as well as in the e2e execution. Do you have any ideas on how to fix that?
* Added comments on the new logout handler function. * Replaced local function isUrl by URL.canParse. * Adjusted post-logout URL construction. * Updated logout flow in e2e login tests.
garciafdezpatricia
had a problem deploying
to
ESS PodSpaces
GitHub Actions
Failure
garciafdezpatricia
had a problem deploying
to
ESS Dev-2-2
GitHub Actions
Failure
- Updated @inrupt/solid-client-authn-browser and @inrupt/solid-client-authn-node to last version, with the bug fix for the parsing of clientAppId. - Added a workaround for URL.canParse as lint was complaining about it. - Updated index e2e test as it was before to check if it still needs the change.
garciafdezpatricia
had a problem deploying
to
ESS PodSpaces
GitHub Actions
Failure
garciafdezpatricia
had a problem deploying
to
ESS Dev-2-2
GitHub Actions
Error
garciafdezpatricia
had a problem deploying
to
ESS PodSpaces
GitHub Actions
Error
garciafdezpatricia
had a problem deploying
to
ESS Dev-2-2
GitHub Actions
Error
garciafdezpatricia
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
garciafdezpatricia
temporarily deployed
to
ESS Dev-2-2
GitHub Actions
Inactive
NSeydoux
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: logging out of OPs that support Solid-OIDC and those that do not.
Description of changes
When logging out from an OP, AMC was sending a post-logout URL as part of the metadata used in DCR. This is incorrect for those OPs that don't support Solid-OIDC Client Identifiers, resulting in an error being shown to the user.
AMC now distinguishes between OPs supporting Solid-OIDC and those that do not, logging the user out accordingly.
User testing instructions
Commit checklist
Design requirements checklist