Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use VERCEL_URL in client ID generation #37

Merged
merged 1 commit into from
May 17, 2024
Merged

Use VERCEL_URL in client ID generation #37

merged 1 commit into from
May 17, 2024

Conversation

acoburn
Copy link
Contributor

@acoburn acoburn commented May 16, 2024

Use VERCEL_URL in client ID generation

Description of changes

Rather than using a client-supplied header (which is subject to manipulation), the client ID document generation is driven by the configured next.js environment value.

User testing instructions

Commit checklist

  • All acceptance criteria are met.
  • Includes tests to ensure functionality, accessibility and prevent regressions, including E2E tests for supported browsers.
  • Relevant documentation, if any, has been written/updated.
  • The changelog has been updated, if applicable.
  • A changeset version has been created, if applicable.
  • Meets Inrupt coding standards and adheres to commit conventions.

Design requirements checklist

  • Meets Inrupt API Design and UX standards
  • Is responsive to our documented minimum supported screen size + resolution
  • Code is extensible by external contributors or anyone forking

@acoburn acoburn requested a review from a team as a code owner May 16, 2024 20:20
@vercel Vercel
Copy link

vercel bot commented May 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
authorization-management-component ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 8:20pm

@acoburn acoburn enabled auto-merge (squash) May 16, 2024 20:42
@acoburn acoburn merged commit 8e7c9a6 into main May 17, 2024
9 checks passed
@acoburn acoburn deleted the use-base-url-from-env branch May 17, 2024 07:06
davidboweninrupt added a commit that referenced this pull request May 20, 2024
@davidboweninrupt
Revert "Use VERCEL_URL in client ID generation (#37)"
dc6fad2 
This reverts commit 8e7c9a6.
davidboweninrupt added a commit that referenced this pull request May 20, 2024
@davidboweninrupt
Revert client id changes (#41)
6802143 
* Revert "Chore(deps-dev): bump ts-node from 10.9.1 to 10.9.2 (#39)"

This reverts commit 487f5c9.

* Revert "Use VERCEL_URL in client ID generation (#37)"

This reverts commit 8e7c9a6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NSeydoux NSeydoux NSeydoux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acoburn @NSeydoux