-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use better type safety when creating URLs #36
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. The preview fails on login, but that is because of Vercel. More things happen in the preview than I realized: if you curl https://authorization-management-component-jzsxmwmmk-inrupt.vercel.app/api/app
, you get a result very different from what I anticipated.
Improve type safety of URLs generated for a client ID document
Description of changes
At present, the URLs used in a rendered client ID document use string concatenation based on a client-supplied header, which could open the door to malicious behavior, especially if the redirect URLs are manipulated.
User testing instructions
Commit checklist
Design requirements checklist