allow no packaging, add template used to generated headers #957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NSeydoux
approved these changes
Mar 12, 2024
| @@ -705,6 +705,7 @@ module.exports = class DatasetHandler { | |||
| result.sourceRdfResources = `Vocabulary built from ${describeInput( | |||
| this.vocabData, | |||
| )}.`; | |||
| result.sourceTemplateVocab = describeTemplateVocab(this.vocabData); | |||
There was a problem hiding this comment.
Ideally, separate features are added through separate PRs.
There was a problem hiding this comment.
Yeah, I know, but I just don't think we have the resource capacity to review multiple PRs in a timely fashion right now (unfortunately), as each review requires a costly 'context switch' for the reviewer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New feature description
Not really a new feature, but this change allows YAML files with no packaging info at all, for cases where we just want vocab file generation without packaging up, or publishing.
Checklist
index.ts, if applicable.