feat(ui): Flag addresses as own or foreign [LW-10061] #998
Conversation
DominikGuzei
changed the title
DominikGuzei
changed the title
Allure report
smokeTests: ✅ test report for b1f7f455
|
|
coverage: 50.845% (+0.2%) from 50.62% |
DominikGuzei
force-pushed
the
feat/lw-10061-flag-addresses-as-own-or-foreign
branch
3 times, most recently
from
968b1a1 to
85ec6b4
Compare
| color: vars.colors.$address_tag_own_color, | ||
| backgroundColor: vars.colors.$address_tag_own_bgColor, | ||
| }, | ||
| [AddressTagVariants.Handle]: { |
There was a problem hiding this comment.
This is not used yet but was visible in the designs and so i already had implemented it before clarifying the smaller scope of the ticket. I would suggest to leave it here for later usage when we implement tagging handles
| 'addr_test1qzqgfww9svrzelxrnlml0nmdq4yevwke7ck7ae27u5ptmq5dwuq25p4hr0yxhg4pce0d6t7v4c0msy3vr3xppygn9ktqe77950' | ||
| ); | ||
|
|
||
| const PXLAssetId = Wallet.Cardano.AssetId('1ec85dcee27f2d90ec1f9a1e4ce74a667dc9be8b184463223f9c960150584c'); |
There was a problem hiding this comment.
I just picked one existing asset I found in the SDK for this storybook example, could be any
| module.exports = () => { | ||
| return { | ||
| testFramework: { | ||
| configFile: 'test/jest.config.js' |
There was a problem hiding this comment.
This file is necessary to run Wallaby.js test runner in the core package which cannot handle our unusual jest setup (config nested in test folder`) by default
DominikGuzei
force-pushed
the
feat/lw-10061-flag-addresses-as-own-or-foreign
branch
from
85ec6b4 to
ceea841
Compare
github-actions
bot
removed
browser
| @@ -0,0 +1,27 @@ | |||
| import * as React from 'react'; | |||
DominikGuzei
force-pushed
the
feat/lw-10061-flag-addresses-as-own-or-foreign
branch
7 times, most recently
from
07aac21 to
3e39c9e
Compare
…vity details LW-10061
DominikGuzei
force-pushed
the
feat/lw-10061-flag-addresses-as-own-or-foreign
branch
from
3e39c9e to
b1f7f45
Compare
|
* feat(ui): add address tag ui component LW-10061 * feat(extension): flag own, address book and foreign addresses in dapp txs LW-10061 * feat(extension): flag own, address book and foreign addresses in activity details LW-10061
Checklist
Proposed solution
adds a new
AddressTagcomponent to the@lace/uitoolkit with variants:Integrates the logic + address tag component in DApp tx summary (from/to section) and activity feed details
Screenshots
DApp tx summary:
Tx Activity details:
