feat(core, extension): add balance style to the dapp bridge [LW-9887] #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes unknown |
lucas-barros
approved these changes
Mar 7, 2024
VanessaPC
reviewed
Mar 8, 2024
packages/ui/src/design-system/dapp-transaction-summary/dapp-transaction-summary.css.ts
Outdated
Show resolved
Hide resolved
VanessaPC
reviewed
Mar 8, 2024
packages/core/src/ui/components/DappAddressSections/DappAddressSections.module.scss
Show resolved
Hide resolved
| @@ -144,9 +145,9 @@ export const DappTransaction = ({ | |||
| ))} | |||
| </div> | |||
|
|
|||
| {collateral && ( | |||
| {collateral !== BigInt(0) && ( | |||
There was a problem hiding this comment.
I see collateral is optional. Does this condition check prevents us from displaying when collateral is undefined?
There was a problem hiding this comment.
good catch, will add the additional check 👍
There was a problem hiding this comment.
fixed in 82c5116c3fe64d219d7edd351298901aeabf6056
DominikGuzei
force-pushed
the
feat/lw-9887-add-balance-style-to-the-dapp-bridge
branch
from
7c55b60 to
9fe2fcb
Compare
Allure report
smokeTests: ❌ test report for d1cb93db
|
packages/ui/src/design-system/dapp-transaction-summary/dapp-transaction-assets.component.tsx
Outdated
Show resolved
Hide resolved
DominikGuzei
force-pushed
the
feat/lw-9887-add-balance-style-to-the-dapp-bridge
branch
from
9fe2fcb to
db655dc
Compare
VanessaPC
approved these changes
Mar 11, 2024
DominikGuzei
force-pushed
the
feat/lw-9887-add-balance-style-to-the-dapp-bridge
branch
2 times, most recently
from
c618ad5 to
2bf5939
Compare
DominikGuzei
force-pushed
the
feat/lw-9887-add-balance-style-to-the-dapp-bridge
branch
3 times, most recently
from
5a3035f to
03544dc
Compare
DominikGuzei
force-pushed
the
feat/lw-9887-add-balance-style-to-the-dapp-bridge
branch
from
03544dc to
d1cb93d
Compare
|
bslabiak
approved these changes
Mar 22, 2024
DominikGuzei
merged this pull request
into
feat/lw-9145-tx-summary-refactor
11 of 16 checks passed
DominikGuzei
deleted the
feat/lw-9887-add-balance-style-to-the-dapp-bridge
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Proposed solution
There has been a small style change in the wallet activity to differentiate operations that are negative or positive so users don’t have any doubt about the balance change in their wallet. This task is about bringing the same styling to the dapp bridge.
Testing
Try various DApp transactions and check that:
Screenshots