-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core,extension): LW-9743 revamp "Save your recovery phrase" screen #919
Conversation
daa2543
to
e4ed066
Compare
8d750a3
to
7601001
Compare
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Allure report
smokeTests: ❌ test report for 7601001f
|
<MnemonicVideoPopupContent | ||
translations={mnemonicVideoPopupContentTranslations} | ||
onClickVideo={() => { | ||
// TODO: https://input-output.atlassian.net/browse/LW-9761 handle analytics here based on the stage argument |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good adding TODOs with a JIRA ticket 💪
|
||
.title { | ||
@include text-heading; | ||
color: var(--text-color-primary, #3d3b39); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if we need #3d3b39 as a fallback. I mean, if we lack --text-color-primary we would not notice it.
position: relative; | ||
height: 272px; | ||
border-radius: 16px; | ||
border: 1px solid #efefef; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we don't use --text-color-secondary or similar instead of #efefef?
const [mnemonicStage, setMnemonicStage] = useState<MnemonicStage>('writedown'); | ||
const [mnemonicConfirm, setMnemonicWordsConfirm] = useState(initialMnemonicWordsConfirm); | ||
const [isWriting, setIsWriting] = useState(false); | ||
const [videoModalOpen, setVideoModalOpen] = useState(false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider whether the mnemonicStage, videoModalOpen, and isWriting states could be consolidated or managed with a single state variable. This would reduce IMO complexity.
const [formState, setFormState] = useState({
stage: 'writedown',
isVideoModalOpen: false,
isWriting: false
});
Also use is/has/contains/can for videoModalOpen (old discussion 😂)
{ key: WalletTimelineSteps.ALL_DONE, name: i18n.t('package.core.walletSetupStep.allDone') } | ||
]; | ||
|
||
const walletSteps = isHardwareWallet ? hardwareWalletSteps : inMemoryWalletSteps; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const walletSteps = isHardwareWallet
? [
{ key: WalletTimelineSteps.LEGAL_AND_ANALYTICS, name: i18n.t('package.core.walletSetupStep.legalAndAnalytics') },
{ key: WalletTimelineSteps.CONNECT_WALLET, name: i18n.t('package.core.walletSetupStep.connectWallet') },
{ key: WalletTimelineSteps.NAME_WALLET, name: i18n.t('package.core.walletSetupStep.nameWallet') },
{ key: WalletTimelineSteps.ALL_DONE, name: i18n.t('package.core.walletSetupStep.allDone') }
]
: [
{ key: WalletTimelineSteps.LEGAL_AND_ANALYTICS, name: i18n.t('package.core.walletSetupStep.legalAndAnalytics') },
{ key: WalletTimelineSteps.WALLET_SETUP, name: i18n.t('package.core.walletSetupStep.walletSetup') },
{ key: WalletTimelineSteps.RECOVERY_PHRASE, name: i18n.t('package.core.walletSetupStep.recoveryPhrase') },
{ key: WalletTimelineSteps.ALL_DONE, name: i18n.t('package.core.walletSetupStep.allDone') }
];
Checklist
Proposed solution
Testing
Just go with the onboarding
Screenshots