fix(staking): clicking on drift warning not working (popup) LW-9438 #918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommayeliog
requested review from
mchappell,
vetalcore and
przemyslaw-wlodek
Allure report
smokeTests: ✅ test report for 0862f612
|
|
Changes unknown |
przemyslaw-wlodek
approved these changes
Feb 26, 2024
vetalcore
approved these changes
Feb 26, 2024
vetalcore
requested changes
Feb 28, 2024
vetalcore
approved these changes
Feb 29, 2024
wklos-iohk
approved these changes
Mar 1, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Proposed solution
I'm using URL SearchParams to pass an action to the new tab when load expanded View.
Affected banners that reads popupView: boolean are:
Testing
test both for expanded and popup views for browserEpanding
Screenshots
After clicking on:
A new browser tab with expanded view + drawer has been opened for Manage Portfolio
