Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(extension): fix subtitle for staking success drawer #914

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

vetalcore
Copy link
Contributor

@vetalcore vetalcore commented Feb 23, 2024

Checklist

  • JIRA - LW-7488
  • Proper tests implemented
  • Screenshots added.

Proposed solution

Use proper translation key.

Testing

Reproducible only for non multi-staking scenario (use proper HW device and USE_MULTI_DELEGATION_STAKING_LEDGER or USE_MULTI_DELEGATION_STAKING_TREZOR should be set to false)

Screenshots

Attach screenshots here if implementation involves some UI changes

@vetalcore vetalcore self-assigned this Feb 23, 2024
@vetalcore vetalcore requested a review from a team as a code owner February 23, 2024 11:17
@github-actions github-actions bot added the browser Changes to the browser application. label Feb 23, 2024
Copy link

sonarcloud bot commented Feb 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Allure report

allure-report-publisher generated test report!

smokeTests: ✅ test report for b9a6cb37

passed failed skipped flaky total result
Total 32 0 0 0 32

@coveralls
Copy link

Coverage Status

Changes unknown
when pulling b9a6cb3 on fix/LW-7488-fix-staking-success-drawer-subtitle
into ** on main**.

Copy link
Contributor

@tommayeliog tommayeliog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍺

@vetalcore vetalcore merged commit b5e26ac into main Feb 27, 2024
9 of 10 checks passed
@vetalcore vetalcore deleted the fix/LW-7488-fix-staking-success-drawer-subtitle branch February 27, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser Changes to the browser application.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants