Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LW-9170 - Add UI fixes to multiaccount #912

Merged
merged 4 commits into from
Feb 28, 2024

Conversation

VanessaPC
Copy link
Contributor

@VanessaPC VanessaPC commented Feb 22, 2024

Checklist

Note: on draft while working on a new bug

  • JIRA - LW-9842
  • Proper tests implemented
  • Screenshots added.

Proposed solution

  • add ellipsis for the title name of the account
  • manage the z-index of the menu element correctly
  • add a link to the tooltip text

Testing

  • Create an account with long title, trigger the dropdown

Screenshots

  • adding ellipsis
Screenshot 2024-02-22 at 15 46 54
  • menu not showing on creating new accounts
    Screenshot 2024-02-23 at 09 20 49

  • add link to open dashboard
    Screenshot 2024-02-23 at 09 39 45
    Screenshot 2024-02-23 at 09 39 31

@VanessaPC VanessaPC self-assigned this Feb 22, 2024
@VanessaPC VanessaPC requested a review from a team as a February 22, 2024 15:29
@github-actions github-actions bot added the browser Changes to the browser application. label Feb 22, 2024
@VanessaPC VanessaPC force-pushed the fix/lw-9842-ui-fixes-multi-wallet branch from 5af90e1 to 99ff360 Compare February 22, 2024 15:46
@VanessaPC VanessaPC marked this pull request as draft February 22, 2024 15:47
@coveralls
Copy link

coveralls commented Feb 22, 2024

Coverage Status

Changes unknown
when pulling f0fda15 on fix/lw-9842-ui-fixes-multi-wallet
into ** on main**.

Copy link

github-actions bot commented Feb 23, 2024

Allure report

allure-report-publisher generated test report!

smokeTests: ✅ test report for f0fda154

passed failed skipped flaky total result
Total 32 0 0 0 32

@VanessaPC VanessaPC changed the title fix: add ellipsis to account title LW-9170 - Add UI fixes to multiaccount Feb 23, 2024
@VanessaPC VanessaPC marked this pull request as ready for review February 23, 2024 10:13
@@ -1404,7 +1404,7 @@
"wallet": "Wallet \"{{walletName}}\" activated",
"account": "Account \"{{accountName}}\" activated"
},
"popupHwAccountEnable": "Hardware wallets require the expanded view to enable accounts",
"popupHwAccountEnable": "Hardware wallets require the <0>expanded view</0> to enable accounts",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, didn't know about this 😎

@tomislavhoracek tomislavhoracek force-pushed the LW-9170-multi-wallet-integration branch from daa2543 to e4ed066 Compare February 27, 2024 08:57
@VanessaPC VanessaPC force-pushed the fix/lw-9842-ui-fixes-multi-wallet branch from c1f4b54 to 2373d7e Compare February 28, 2024 11:05
Base automatically changed from LW-9170-multi-wallet-integration to main February 28, 2024 11:22
@VanessaPC VanessaPC force-pushed the fix/lw-9842-ui-fixes-multi-wallet branch from 2373d7e to 033fc68 Compare February 28, 2024 11:29
Copy link

sonarcloud bot commented Feb 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@VanessaPC VanessaPC merged commit 6e2d3fb into main Feb 28, 2024
11 of 13 checks passed
@VanessaPC VanessaPC deleted the fix/lw-9842-ui-fixes-multi-wallet branch February 28, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser Changes to the browser application.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants