[LW-9813] Create posthog alias after new wallet is restored #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucas-barros
changed the base branch from
main
to
LW-9170-multi-wallet-integration
Allure report
smokeTests: ✅ test report for b1c8acd4
|
lucas-barros
force-pushed
the
feat/lw-9813-create-posthog-alias-after-new-wallet-is-restored
branch
2 times, most recently
from
dd8c73b to
c8c7217
Compare
|
Changes unknown |
lucas-barros
force-pushed
the
feat/lw-9813-create-posthog-alias-after-new-wallet-is-restored
branch
2 times, most recently
from
c76c207 to
d7da760
Compare
| connectedDevice: model, | ||
| deviceConnection: connection, | ||
| name, | ||
| accountIndex: account | ||
| }); | ||
| await analytics.sendMergeEvent(source.account.extendedAccountPublicKey); |
There was a problem hiding this comment.
Are we sure we want to send the public key in plain text?
There was a problem hiding this comment.
Its not sent as is. Its hashed first with generateWalletBasedUserId.
| @@ -53,7 +56,8 @@ export const RestoreRecoveryPhrase = (): JSX.Element => { | |||
| }} | |||
| onSubmit={useCallback(async () => { | |||
| try { | |||
| await createWallet(data); | |||
| const { source } = await createWallet(data); | |||
| await analytics.sendMergeEvent(source.account.extendedAccountPublicKey); | |||
There was a problem hiding this comment.
Are we sure we want to send & save the public key in plain text?
There was a problem hiding this comment.
It's not sent as is. It's hashed first with generateWalletBasedUserId.
VanessaPC
reviewed
Feb 23, 2024
...ension-wallet/src/views/browser-view/features/wallet-setup/components/HardwareWalletFlow.tsx
Show resolved
Hide resolved
DominikGuzei
approved these changes
Feb 26, 2024
tomislavhoracek
force-pushed
the
LW-9170-multi-wallet-integration
branch
from
daa2543 to
e4ed066
Compare
lucas-barros
force-pushed
the
feat/lw-9813-create-posthog-alias-after-new-wallet-is-restored
branch
from
d7da760 to
5a847e6
Compare
lucas-barros
force-pushed
the
feat/lw-9813-create-posthog-alias-after-new-wallet-is-restored
branch
2 times, most recently
from
9f3fdb4 to
caa9ebc
Compare
lucas-barros
force-pushed
the
feat/lw-9813-create-posthog-alias-after-new-wallet-is-restored
branch
from
caa9ebc to
d30d8fa
Compare
lucas-barros
force-pushed
the
feat/lw-9813-create-posthog-alias-after-new-wallet-is-restored
branch
from
d30d8fa to
b1c8acd
Compare
|
bslabiak
approved these changes
Mar 11, 2024
lucas-barros
deleted the
feat/lw-9813-create-posthog-alias-after-new-wallet-is-restored
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Proposed solution
Testing
Posthog user aliasing
Hardware wallet operations immediately after onboarding
Screenshots
Attach screenshots here if implementation involves some UI changes