feat(staking,extension,ui): StakePools Grid and List View integration, persistance adjustments [LW-9250, LW-9393, LW-9249, LW-9922] #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
browser
Allure report
smokeTests: ✅ test report for 7379be5d
|
|
Changes unknown |
przemyslaw-wlodek
force-pushed
the
feat/LW-9250-LW-9393-browse-pools-sorting
branch
from
8a2f312 to
3ad58cc
Compare
przemyslaw-wlodek
force-pushed
the
feat/LW-9250-LW-9393-browse-pools-sorting
branch
from
3ad58cc to
50118e4
Compare
…browse-pools-sorting
… of SortField type
github-actions
bot
added
e2e
…browse-pools-sorting
…matters and fix TS errors
przemyslaw-wlodek
force-pushed
the
feat/LW-9250-LW-9393-browse-pools-sorting
branch
from
777a1a9 to
990ae8b
Compare
vetalcore
approved these changes
Mar 14, 2024
…browse-pools-sorting
…browse-pools-sorting
|
wklos-iohk
approved these changes
Mar 22, 2024
mchappell
approved these changes
Mar 22, 2024
| { updateLocalStorage: setMultidelegationFirstVisitSincePortfolioPersistence } | ||
| ] = useLocalStorage(MULTIDELEGATION_FIRST_VISIT_SINCE_PORTFOLIO_PERSISTENCE_LS_KEY, true); | ||
| const sendAnalytics = useCallback(() => { | ||
| // TODO implement analytics for the new flow |
There was a problem hiding this comment.
covering in LW-9993 and LW-9994, out of scope for this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Proposed solution
This PR integrates the List and Grid view with business logic, including changes to the settings persistence (e.g. preferred view and selected stake pools). Introducing usage of ROS instead of APY (deprecated) and some necessary bug fixes around that.
New env variables:
USE_MULTI_DELEGATION_STAKING_FILTERS- shows filters tab iftrueChanges to the existing env variables:
USE_ROS_STAKING_COLUMN- if set tofalsethe "ROS" sorting option won't be available in the top-right corner sort/filter preferences cardTesting
Please run full regression on Staking and check the env variables. Be sure to include some of the following edge cases with different search queries/sorting/pool selections:
Screenshots