Feat/lw 9709 prompt password when unlocking account #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allure report
smokeTests: ✅ test report for 6f51d253
|
lucas-barros
approved these changes
Feb 20, 2024
...s/core/src/ui/components/Account/EnableAccountPasswordPrompt/EnableAccountPasswordPrompt.tsx
Outdated
Show resolved
Hide resolved
...s/core/src/ui/components/Account/EnableAccountPasswordPrompt/EnableAccountPasswordPrompt.tsx
Outdated
Show resolved
Hide resolved
...r-extension-wallet/src/components/MainMenu/DropdownMenuOverlay/components/WalletAccounts.tsx
Outdated
Show resolved
Hide resolved
mkazlauskas
requested changes
Feb 20, 2024
DominikGuzei
force-pushed
the
feat/lw-9709-prompt-password-when-unlocking-account
branch
from
82a4290 to
eb83e6f
Compare
mkazlauskas
requested changes
Feb 21, 2024
...s/core/src/ui/components/Account/EnableAccountPasswordPrompt/EnableAccountPasswordPrompt.tsx
Outdated
Show resolved
Hide resolved
...s/core/src/ui/components/Account/EnableAccountPasswordPrompt/EnableAccountPasswordPrompt.tsx
Outdated
Show resolved
Hide resolved
...s/core/src/ui/components/Account/EnableAccountPasswordPrompt/EnableAccountPasswordPrompt.tsx
Outdated
Show resolved
Hide resolved
...r-extension-wallet/src/components/MainMenu/DropdownMenuOverlay/components/WalletAccounts.tsx
Outdated
Show resolved
Hide resolved
|
Changes unknown |
DominikGuzei
force-pushed
the
feat/lw-9709-prompt-password-when-unlocking-account
branch
2 times, most recently
from
b80c193 to
4e69bb1
Compare
tomislavhoracek
force-pushed
the
LW-9170-multi-wallet-integration
branch
from
daa2543 to
e4ed066
Compare
DominikGuzei
force-pushed
the
feat/lw-9709-prompt-password-when-unlocking-account
branch
from
4e69bb1 to
eb8e061
Compare
DominikGuzei
force-pushed
the
feat/lw-9709-prompt-password-when-unlocking-account
branch
from
eb8e061 to
3459e98
Compare
DominikGuzei
force-pushed
the
feat/lw-9709-prompt-password-when-unlocking-account
branch
2 times, most recently
from
1d0809c to
9a16fb1
Compare
mkazlauskas
approved these changes
Mar 1, 2024
apps/browser-extension-wallet/src/hooks/__tests__/useWalletManager.test.tsx
Outdated
Show resolved
Hide resolved
|
@mkazlauskas @lucas-barros ready for a final code review (as scope was extended to cover the hardware wallets flow for enabling accounts) |
DominikGuzei
force-pushed
the
feat/lw-9709-prompt-password-when-unlocking-account
branch
from
9a16fb1 to
d500763
Compare
mkazlauskas
approved these changes
Mar 1, 2024
DominikGuzei
force-pushed
the
feat/lw-9709-prompt-password-when-unlocking-account
branch
3 times, most recently
from
fe0b991 to
3e9991e
Compare
The PasswordBox component layout in lace/ui wasn't responsive and broke in different width scenarios. This commit fixes the layout issues so that the password box can have any size.
This is the basis of the core component which will later be wired-up in Lace to prompt for the wallet password when enabling an account.
extracted the password prompting out of the wallet manager into the UI and optionally pass it down instead.
DominikGuzei
force-pushed
the
feat/lw-9709-prompt-password-when-unlocking-account
branch
from
3e9991e to
6f51d25
Compare
|
DominikGuzei
deleted the
feat/lw-9709-prompt-password-when-unlocking-account
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Proposed solution
This PR implements the password prompt to enable an in-memory account as well as the respective hardware wallet flows.
Screenshots
Password prompt:
Incorrect password entered: