Lw 9170 multi wallet integration #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allure report
smokeTests: ✅ test report for bd11e2ef
|
...browser-extension-wallet/src/components/MainMenu/DropdownMenuOverlay/components/UserInfo.tsx
Show resolved
Hide resolved
...browser-extension-wallet/src/components/MainMenu/DropdownMenuOverlay/components/UserInfo.tsx
Outdated
Show resolved
Hide resolved
...r-extension-wallet/src/components/MainMenu/DropdownMenuOverlay/components/WalletAccounts.tsx
Outdated
Show resolved
Hide resolved
...r-extension-wallet/src/components/MainMenu/DropdownMenuOverlay/components/WalletAccounts.tsx
Outdated
Show resolved
Hide resolved
DominikGuzei
approved these changes
Feb 15, 2024
|
Changes unknown |
...s/ui/src/design-system/profile-dropdown/accounts/profile-dropdown-account-item.component.tsx
Show resolved
Hide resolved
...r-extension-wallet/src/components/MainMenu/DropdownMenuOverlay/components/WalletAccounts.tsx
Outdated
Show resolved
Hide resolved
|
@mkazlauskas thanks for the updates, all green from my side 🚢 |
mkazlauskas
force-pushed
the
LW-9170-multi-wallet-integration
branch
2 times, most recently
from
9337d2f to
c2d6a83
Compare
renanvalentin
approved these changes
Feb 19, 2024
...s/ui/src/design-system/profile-dropdown/accounts/profile-dropdown-account-item.component.tsx
Show resolved
Hide resolved
mkazlauskas
force-pushed
the
LW-9170-multi-wallet-integration
branch
2 times, most recently
from
282e3ce to
7a410ef
Compare
|
Please do not merge https://input-output.atlassian.net/browse/LW-9170?focusedCommentId=260303 |
…t flow if create wallet flow finishes without explicitly calling setBackgroundPage() then it would break the routing, as background page would be defined forever
temporarily use native prompt dialog for password input; does not have a prompt to connect hardware wallet, or any error handling when deriving xpub
If it takes more than some time (probably 50ms), Chrome will reject hardware device connection with an error that says WebHID connections must be initiated from user gesture. Apparently, fetching wallets from repository can sometimes take longer. This fix updates useWalletManager addAccount method to take in the entire AnyBip32Wallet object instead of just walletId, so that it doesn't have to fetch the wallet object from indexeddb in service worker. Consequently, some validations from addAccount can be removed, because it's signature no longer accepts walletId of a script wallet. Also it has to trust that wallet actually exists, otherwise it will reject with an error that comes from the WalletRepository (it is no longer a responsibility of this method to check the existence of the wallet).
clicking on a wallet in dropdown menu activates it removing copy feature makes the behavior more predictable
show tooltip that explains the behavior
also decouple button color scheme from size scheme and set minWidth for ExtraSmall button, which is currently only used for profile dropdown account item
temporary design until we apply a larger re-design
toast is a temporary solution, to be replaced
onboarding, adding wallet, adding accounts and dapp transacations are now working
required for correctly bundling trezor
after removing imports from dist/cjs, service worker no longer loads this is a temporary solution
tomislavhoracek
force-pushed
the
LW-9170-multi-wallet-integration
branch
from
daa2543 to
e4ed066
Compare
|
Rebased and fixed "abs / relative paths" conflicts ( kept changes Martynas introduced ). |
|
@pczeglik-iohk I Checked 5b2832a Approved! 💯 🚀 |
apps/browser-extension-wallet/src/hooks/__tests__/useWalletManager.test.tsx
Outdated
Show resolved
Hide resolved
pczeglik-iohk
force-pushed
the
LW-9170-multi-wallet-integration
branch
from
5b2832a to
bd11e2e
Compare
|
bslabiak
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Proposed solution
Integrate multi-wallet/account UI components with SDK utilities
Out of scope: enter password/connect hardware modal when enabling accounts (LW-9709)
Testing
Requires
USE_MULTI_WALLET=trueScreenshots