[LW-9742]: use new register screen for create wallet flow #891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
greatertomi
requested changes
Feb 15, 2024
...tension-wallet/src/views/browser-view/features/wallet-setup/components/WalletSetupWizard.tsx
Outdated
Show resolved
Hide resolved
...tension-wallet/src/views/browser-view/features/wallet-setup/components/WalletSetupWizard.tsx
Outdated
Show resolved
Hide resolved
...tension-wallet/src/views/browser-view/features/wallet-setup/components/WalletSetupWizard.tsx
Outdated
Show resolved
Hide resolved
...tension-wallet/src/views/browser-view/features/wallet-setup/components/WalletSetupWizard.tsx
Outdated
Show resolved
Hide resolved
...tension-wallet/src/views/browser-view/features/wallet-setup/components/WalletSetupWizard.tsx
Outdated
Show resolved
Hide resolved
...tension-wallet/src/views/browser-view/features/wallet-setup/components/WalletSetupWizard.tsx
Outdated
Show resolved
Hide resolved
...tension-wallet/src/views/browser-view/features/wallet-setup/components/WalletSetupWizard.tsx
Outdated
Show resolved
Hide resolved
|
Also, the master branch has several changes, can you please update this branch? |
Allure report
smokeTests: ❌ test report for 4be6f22c
|
shawnbusuttil
changed the base branch from
main
to
feat/lw-9740-revamp-create-wallet-screen
shawnbusuttil
changed the base branch from
feat/lw-9740-revamp-create-wallet-screen
to
LW-9170-multi-wallet-integration
shawnbusuttil
changed the base branch from
LW-9170-multi-wallet-integration
to
feat/lw-9740-revamp-create-wallet-screen
shawnbusuttil
changed the title
shawnbusuttil
changed the base branch from
feat/lw-9740-revamp-create-wallet-screen
to
main
shawnbusuttil
changed the base branch from
main
to
feat/lw-9740-revamp-create-wallet-screen
greatertomi
force-pushed
the
feat/lw-9740-revamp-create-wallet-screen
branch
from
eebf610 to
628e962
Compare
shawnbusuttil
force-pushed
the
feat/lw-9742-use-new-register-screen
branch
from
1f5561e to
52db2f5
Compare
shawnbusuttil
changed the base branch from
feat/lw-9740-revamp-create-wallet-screen
to
main
shawnbusuttil
changed the title
greatertomi
approved these changes
Feb 29, 2024
greatertomi
changed the base branch from
main
to
feat/lw-9651-revamp-onboarding-develop-branch
greatertomi
force-pushed
the
feat/lw-9651-revamp-onboarding-develop-branch
branch
from
bbe4603 to
13c100c
Compare
…t/lw-9742-use-new-register-screen
|
greatertomi
merged commit d387379
into
feat/lw-9651-revamp-onboarding-develop-branch
4 of 7 checks passed
greatertomi
added a commit
that referenced
this pull request
Mar 5, 2024
emiride
added a commit
that referenced
this pull request
Mar 25, 2024
* feat: move pin extension notification to main screen (#902) * feat: move pin extension notification to main screen * fix: start notification timeout only when modal is close * fix: notification useEffect improvement * feat: improve hardware wallet setup on onboarding flow (#909) * feat(extension): remove beta dapp modal (#921) * feat(extension): remove beta dapp modal * test(extension): remove beta dapp modal --------- Co-authored-by: emiride <[email protected]> * feat: [LW-9740] remove legal and analytics page from onboarding flow (#890) * feat: create confirmation banner * feat: add analytics modal and landing page improvements * feat: remove legal and analytics step on onboarding * refactor: extract revamped screens from multi-wallet flow * feat: [lw-9742] use new register screen for create wallet flow * feat: [lw-9745]: revamp mnemonic verification * fix: improvements * [LW-9742]: use new register screen for create wallet flow (#891) * feat: move pin extension notification to main screen (#902) * feat: move pin extension notification to main screen * fix: start notification timeout only when modal is close * fix: notification useEffect improvement * feat: improve hardware wallet setup on onboarding flow (#909) * feat(extension): remove beta dapp modal (#921) * feat(extension): remove beta dapp modal * test(extension): remove beta dapp modal --------- Co-authored-by: emiride <[email protected]> * feat: [LW-9740] remove legal and analytics page from onboarding flow (#890) * feat: create confirmation banner * feat: add analytics modal and landing page improvements * feat: remove legal and analytics step on onboarding * refactor: extract revamped screens from multi-wallet flow * feat: [lw-9742] use new register screen for create wallet flow (#891) * feat: [lw-9745]: revamp mnemonic verification * refactor: enable paste functionality for keyboard * feat: adapt mnemonic length switcher to dark mode * fix: styling and mnemonic pasting issues * fix: remove recovery phrase length screen and clear clipboard after paste * fix: focus automatically on first input field * feat: show multi-address modal post wallet creation (#923) * feat: show multi-address modal post wallet creation * refactor: relocate multi-address modal * fix: ensure pop-up only displays for multi-address wallet restoration * Test/lw 9921 fix e2e tests (#934) * feat: [lw-9742] use new register screen for create wallet flow * feat: [LW-9740] remove legal and analytics page from onboarding flow (#890) * feat: create confirmation banner * feat: add analytics modal and landing page improvements * feat: remove legal and analytics step on onboarding * refactor: extract revamped screens from multi-wallet flow * test(extension): lw-9921 fix e2e tests in onboarding * test(extension): lw-9921 fix e2e tests in onboarding * test(extension): onboarding fixes * test(extension): fix try 1 * test(extension): fix try 2 * test(extension): fix try 3 * test(extension): fix try 4 * test(extension): cleanup * test(extension): full fix 1 * test(extension): add new multi address modal confirm --------- Co-authored-by: John Oshalusi <[email protected]> Co-authored-by: januszjanus <[email protected]> * fix(core): linting warning/errors * fix: resolve onboarding create restore flow analytics (#936) * fix: analytics in the wallet creation onboarding process * fix: analytics in the wallet restore onboarding process * feat: add analytics for wallet onboarding page * feat: add analytics to multi-address modal * fix(extension): fixed multi-wallet integration tests * fix(extension): ignored test * fix: design inconsistencies between screens * test: fix AnalyticsTracker test * feat: move the register screen after the mnemonic screen for create and restore flow (#945) * feat: move the register screen after the mnemonic screen * refactor: move WalletSetupNamePasswordStep translations into browser folder * fix: more improvements * feat: revamp forgot password flow (#956) * feat: move the register screen after the mnemonic screen * feat: revamp forgot password flow * feat: move the register screen after the mnemonic screen * fix(extension): fix eslint warning * fix(extension): fix more eslint warnings where functions are not returning anything * fix: remove back button on first step of forgot password --------- Co-authored-by: John Oshalusi <[email protected]> Co-authored-by: Daniel Main <[email protected]> Co-authored-by: Emir Hodzic <[email protected]> * feat: update save recovery phrase onboarding text (#966) * fix: revert changes to multi-wallet onboarding flow (#965) * fix: revert changes to multi-wallet onboarding flow * Merge branch 'main' into feat/lw-9651-revamp-onboarding-develop-branch * feat: handle back from next step in wallet setup step (#971) * feat: handle back from next step in wallet setup step * fix: remove unused variable from .env.developerpreview * Feat/lw 9998 revamp e2e fixes (#949) * test(extension): add new multi address modal confirm disabling * test(extension): wip 1 * test(extension): wip 2 * test(extension): wip 3 * test(extension): add new multi address modal confirm disabling * test(extension): wip 1 * test(extension): wip 2 * test(extension): fixed new smoke test * test(extension): wip 4 * test(extension): password checks fix * test(extension): conflicting commits sort out * test(extension): add analytics annotation to analytics features * test(extension): add e2e annotation to all e2e folder feature files * test(extension): add onboarding annotation to all onboarding feature files * test(extension): fix wallet address tests * test(extension): fix forgot password tests * test(extension): fixed test LW-4993 * test(extension): added test ids to mnemonic step * test(extension): various fixes * test(extension): fixed few create wallet tests * test(extension): onboarding create tests fixes * test(extension): onboarding create tests fixes 2 * test(extension): onboarding recovery tests fixes 1 * test(extension): fixes on restore wallet * test(extension): contd fixing onboarding tests * test(extension): fixed onboarding tests * test(extension): fixed onboarding tests * test(extension): additional refactoring * test(extension): removed some unused steps * test(extension): removed some unused steps * test(extension): more fixes * test(extension): more fixes 2 * test(extension): fixed new revamped tests * test(extension): fixed smoke tests * test(extension): refixed create and restore tests * test(extension): smoke fix try 1 * test(extension): smoke fix try 2 * test(extension): smoke fix try 2 * test(extension): smoke fix try 3 * test(extension): smoke fix try 4 * test(extension): smoke fix try 5 * test(extension): smoke fix try 6 * test(extension): smoke fix try 7 * test(extension): smoke fix try 8 * test(extension): smoke fix try 8 * test(extension): smoke fix try 10 * test(extension): various fixes * test(extension): various fixes 2 * test(extension): various fixes 3 * test(extension): smoke fix try * test(extension): cleanup * test(extension): 3761 fix try 1 * test(extension): cleanup 2 * test(extension): cleanup 3 * test(extension): pr comments * test(extension): pr comments * test(extension): pr comments, add analyticsBannerAssert * test(extension): pr comments 2 * test(extension): few minor fixes * test(extension): pr comments 3 * test(extension): fix on comments * test(extension): cleanup * test(extension): cleanup 2 --------- Signed-off-by: Emir Hodzic <[email protected]> Co-authored-by: januszjanus <[email protected]> * fix: update hardware wallet flow to better match revamped onboarding (#979) * fix: update hardware wallet flow to match revamped onboarding --------- Signed-off-by: John Oshalusi <[email protected]> Signed-off-by: Emir Hodzic <[email protected]> Co-authored-by: emiride <[email protected]> Co-authored-by: Shawn <[email protected]> Co-authored-by: shawnbusuttil <[email protected]> Co-authored-by: januszjanus <[email protected]> Co-authored-by: Daniel Main <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Proposed solution
Using the new register screen which unifies name and password steps.
Testing
Describe here, how the new implementation can be tested.
Provide link or briefly describe User Acceptance Criteria/Tests that need to be met
Screenshots