Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(staking): stake pools add sort & filter LW-9250 #867

Merged
merged 42 commits into from
Feb 21, 2024
Merged

feat(staking): stake pools add sort & filter LW-9250 #867

merged 42 commits into from
Feb 21, 2024

Conversation

tommayeliog
Copy link
Contributor

@tommayeliog tommayeliog commented Jan 30, 2024 •
edited by jira bot
Loading

Checklist

Proposed solution

(Co-authoring with Michael Chappell)

The proposed solution is for a new component . State and callbacks are send from the parent.

Testing

Please use Storybook
Known issue is DarkTheme on Storybook is not working properly for Staking.
Window vertical scroll may disappear when opening ROS select input and make the content move left and right,
(probably it's only on Storybook)

Screenshots

Screenshot 2024-02-07 at 20 27 04

@tommayeliog tommayeliog requested a review from mchappell January 30, 2024 23:02
@github-actions github-actions bot added staking Changes to the staking package. ui-toolkit labels Jan 30, 2024
@tommayeliog tommayeliog changed the title Feature/lw 9250 stake pools sort filter feat(staking): stake pools add sort & filter LW-9250 Jan 31, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 1, 2024 •
edited
Loading

Allure report

allure-report-publisher generated test report!

smokeTests: ✅ test report for bdcb7f85

passed failed skipped flaky total result
Total 32 0 0 0 32 ✅

@tommayeliog tommayeliog marked this pull request as ready for review February 5, 2024 16:01
@tommayeliog tommayeliog requested review from a team as code owners February 5, 2024 16:01
vetalcore
vetalcore previously requested changes Feb 5, 2024
View reviewed changes
packages/staking/src/features/BrowsePools/SortAndFilter/SortAndFilter.css.ts Outdated Show resolved Hide resolved
packages/staking/src/features/BrowsePools/SortAndFilter/SortAndFilter.tsx Show resolved Hide resolved
packages/staking/src/features/BrowsePools/SortAndFilter/SortAndFilter.tsx Outdated Show resolved Hide resolved
packages/staking/src/features/BrowsePools/SortAndFilter/SortAndFilter.tsx Outdated Show resolved Hide resolved
packages/staking/src/features/BrowsePools/SortAndFilter/SortAndFilter.tsx Outdated Show resolved Hide resolved
packages/staking/src/features/BrowsePools/SortAndFilter/SortAndFilter.tsx Outdated Show resolved Hide resolved
packages/staking/src/features/BrowsePools/SortAndFilter/utils.ts Outdated Show resolved Hide resolved
packages/ui/src/design-system/radio-button/radio-button.component.tsx Outdated Show resolved Hide resolved
packages/ui/src/design-system/radio-button/radio-button.component.tsx Outdated Show resolved Hide resolved
packages/ui/src/design-system/toggle-button-group/toggle-button-group-item.component.tsx Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Feb 8, 2024 •
edited
Loading

Coverage Status

Changes unknown
when pulling bdcb7f8 on feature/LW-9250-Stake-pools-sort-filter
into ** on main**.

@mchappell mchappell self-requested a review February 12, 2024 12:47
przemyslaw-wlodek and others added 11 commits February 12, 2024 14:41
@przemyslaw-wlodek
refactor(ui): fix spacing in ToggleButtonGroup without children
3d63690
@przemyslaw-wlodek
Merge remote-tracking branch 'origin/main' into feature/LW-9250-Stake…
c05cb83 
…-pools-sort-filter
@przemyslaw-wlodek
refactor(ui): post-merge fixes
ed7286b
@przemyslaw-wlodek
fix(staking): sortAndFilter translations, colors and other QA changes
da17645
@przemyslaw-wlodek
chore(staking): fix storybook after recent changes in main
c331d13
@przemyslaw-wlodek
Merge remote-tracking branch 'origin/main' into feature/LW-9250-Stake…
9a62dde 
…-pools-sort-filter
@przemyslaw-wlodek
Merge remote-tracking branch 'origin/main' into feature/LW-9250-Stake…
51f67b6 
…-pools-sort-filter
@przemyslaw-wlodek
chore(staking): mock @lace/cardano for storybook in Staking
92d6212
@przemyslaw-wlodek
Revert "chore(staking): mock @lace/cardano for storybook in Staking"
32489b8 
This reverts commit 92d6212.
@przemyslaw-wlodek
Merge remote-tracking branch 'origin/main' into feature/LW-9250-Stake…
dc1d8a2 
…-pools-sort-filter
@tommayeliog
feat(extension): adding sort and filter to browser extension
f8b47e8
@github-actions github-actions bot added the browser Changes to the browser application. label Feb 20, 2024
@github-actions github-actions bot removed the browser Changes to the browser application. label Feb 21, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 21, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
3.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@tommayeliog tommayeliog merged commit af41488 into main Feb 21, 2024
15 of 16 checks passed
@tommayeliog tommayeliog deleted the feature/LW-9250-Stake-pools-sort-filter branch February 21, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@przemyslaw-wlodek przemyslaw-wlodek przemyslaw-wlodek approved these changes

@mchappell mchappell mchappell approved these changes

@vetalcore vetalcore vetalcore left review comments

Assignees
No one assigned
Labels
staking Changes to the staking package.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tommayeliog @coveralls @mchappell @vetalcore @przemyslaw-wlodek