-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LW-9459: save user preferences for staking feature #839
Conversation
Allure report
smokeTests: ✅ test report for f46821c5
|
Changes unknown |
ec806a4
to
9a4fe5f
Compare
9a4fe5f
to
7f19131
Compare
packages/staking/src/features/outside-handles-provider/types.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about the ACs, but from the code perspective LGTM ✅ We will need to include state machine in future PRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
multi-staking selection doesn't persist outside of the staking section, please adjust.
Quality Gate passedIssues Measures |
Checklist
Proposed solution
Store user preferences in the local storage.
Pass proper handlers via OutsideHandlesProvider.
Testing
Describe here, how the new implementation can be tested.
Provide link or briefly describe User Acceptance Criteria/Tests that need to be met
Screenshots
Attach screenshots here if implementation involves some UI changes