Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LW-9459: save user preferences for staking feature #839

Merged
merged 17 commits into from
Feb 21, 2024

Conversation

vetalcore
Copy link
Contributor

@vetalcore vetalcore commented Jan 17, 2024

Checklist

  • JIRA - LW-9459
  • Proper tests implemented
  • Screenshots added.

Proposed solution

Store user preferences in the local storage.
Pass proper handlers via OutsideHandlesProvider.

Testing

Describe here, how the new implementation can be tested.
Provide link or briefly describe User Acceptance Criteria/Tests that need to be met

Screenshots

Attach screenshots here if implementation involves some UI changes

@vetalcore vetalcore self-assigned this Jan 17, 2024
@vetalcore vetalcore requested review from a team as code owners January 17, 2024 10:42
@github-actions github-actions bot added browser Changes to the browser application. staking Changes to the staking package. labels Jan 17, 2024
Copy link

github-actions bot commented Jan 17, 2024

Allure report

allure-report-publisher generated test report!

smokeTests: ✅ test report for f46821c5

passed failed skipped flaky total result
Total 32 0 0 0 32

@coveralls
Copy link

coveralls commented Jan 17, 2024

Coverage Status

Changes unknown
when pulling f46821c on feat/LW-9459-staking-user-preferences
into ** on main**.

Base automatically changed from feat/LW-9270-new-stake-pool-table to main January 24, 2024 14:15
@vetalcore vetalcore force-pushed the feat/LW-9459-staking-user-preferences branch 2 times, most recently from ec806a4 to 9a4fe5f Compare January 29, 2024 16:04
@vetalcore vetalcore force-pushed the feat/LW-9459-staking-user-preferences branch from 9a4fe5f to 7f19131 Compare February 4, 2024 00:55
@vetalcore vetalcore changed the title [WIP]: LW-9459: save user preferences for staking feature LW-9459: save user preferences for staking feature Feb 5, 2024
Copy link
Contributor

@przemyslaw-wlodek przemyslaw-wlodek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the ACs, but from the code perspective LGTM ✅ We will need to include state machine in future PRs.

Copy link
Collaborator

@mchappell mchappell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

multi-staking selection doesn't persist outside of the staking section, please adjust.

Copy link

sonarcloud bot commented Feb 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@vetalcore vetalcore enabled auto-merge (squash) February 21, 2024 12:14
@vetalcore vetalcore merged commit e02d87b into main Feb 21, 2024
9 of 10 checks passed
@vetalcore vetalcore deleted the feat/LW-9459-staking-user-preferences branch February 21, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser Changes to the browser application. staking Changes to the staking package.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants