feat(staking): [LW-7508] add un-delegation functionality #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refi93
reviewed
Oct 11, 2023
refi93
reviewed
Oct 11, 2023
refi93
reviewed
Oct 11, 2023
packages/staking/src/features/drawer/preferences/NoPoolsSelected.tsx
Outdated
Show resolved
Hide resolved
refi93
approved these changes
Oct 11, 2023
szymonmaslowski
approved these changes
Oct 12, 2023
packages/staking/src/features/drawer/StakePoolConfirmation.module.scss
Outdated
Show resolved
Hide resolved
packages/staking/src/features/drawer/preferences/NoPoolsSelected.css.ts
Outdated
Show resolved
Hide resolved
przemyslaw-wlodek
requested changes
Oct 24, 2023
packages/staking/src/features/Drawer/preferences/sad-smiley.svg
Outdated
Show resolved
Hide resolved
przemyslaw-wlodek
approved these changes
Oct 24, 2023
Base automatically changed from
feat/LW-8510-delegation-portfolio-store-adjustments
to
main
October 31, 2023 07:52
xdzurman
force-pushed
the
feat/LW-7508-Removing-all-pools-results-in-unstaking-all-funds
branch
from
cc7308a to
430d524
Compare
|
Blocked by a bug in js sdk - https://input-output.atlassian.net/browse/LW-8993 Once a new sdk version is released - update sdk in lace, test and merge this, no further code edits needed |
|
SonarCloud Quality Gate failed.
|
Allure report
smokeTests: ✅ test report for 8cadf68e
|
ljagiela
requested changes
Nov 16, 2023
pczeglik-iohk
force-pushed
the
feat/LW-7508-Removing-all-pools-results-in-unstaking-all-funds
branch
from
c45a62d to
3cab8ca
Compare
pczeglik-iohk
force-pushed
the
feat/LW-7508-Removing-all-pools-results-in-unstaking-all-funds
branch
from
e3b8a60 to
0b9494a
Compare
|
Changes unknown |
pczeglik-iohk
force-pushed
the
feat/LW-7508-Removing-all-pools-results-in-unstaking-all-funds
branch
from
22b90f3 to
4eed6a2
Compare
pczeglik-iohk
force-pushed
the
feat/LW-7508-Removing-all-pools-results-in-unstaking-all-funds
branch
from
4eed6a2 to
8cadf68
Compare
|
mkazlauskas
deleted the
feat/LW-7508-Removing-all-pools-results-in-unstaking-all-funds
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Proposed solution
Always allow removing pools from preferences drawer. If the last pool was removed, render the sad smiley content. I chose the easier alternative to get this out quick - i.e., you can remove pools not just in overview Management drawer, but also in Browse pools to not complicate the code. Also adjusted the result screen (see screenshots).
Testing
Manage current portfolio > Remove all pools > continue, sign the transaction
Screenshots
Allure report
allure-report-publishergenerated test report!smokeTests: ✅ test report for 430d524c