Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [lw 11882] Connect DApp Explorer to DApp Radar API #1649

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

feat: [lw 11882] Connect DApp Explorer to DApp Radar API #1649

wants to merge 11 commits into from

Conversation

szymonmaslowski
Copy link
Contributor

@szymonmaslowski szymonmaslowski commented Jan 17, 2025 •
edited
Loading

Checklist

  • JIRA - <link>
  • Proper tests implemented
  • Screenshots added.

Proposed solution

  • fetching categories from DR API
  • fetching dapps from DR API
    • filtering dapps based on chosen category
  • CI setup to include DR api token from GH seecrets
  • docs on how to get personal api token

Testing

  1. Set up your personal dapp radar api token (check the new readme description)
  2. Build lace
  3. Go to dapp explorer tab

Screenshots

image image image

@szymonmaslowski szymonmaslowski requested review from a team as code owners January 17, 2025 09:57
@pczeglik-iohk
Copy link
Contributor

pczeglik-iohk commented Jan 17, 2025 •
edited
Loading

Allure Report

allure-report-publisher generated test report!

processReports: ❌ test report for 78be196f

passed failed skipped flaky total result
Total 32 2 3 0 37 ❌

greatertomi
greatertomi approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@greatertomi greatertomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work. Looks good to me. 🚀

@szymonmaslowski szymonmaslowski force-pushed the feat/LW-11882-connect-to-dapp-radar branch from a80d784 to 78be196 Compare January 17, 2025 15:51
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greatertomi greatertomi greatertomi approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@szymonmaslowski @pczeglik-iohk @greatertomi