fix: improve hasEnoughAda check when setting collateral #1578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greatertomi
force-pushed
the
fix/lw-11927-collateral-issue
branch
from
7a00d8e to
3273e96
Compare
Allure Report
processReports: ✅ test report for 5feee55e
|
greatertomi
force-pushed
the
fix/lw-11927-collateral-issue
branch
from
3273e96 to
9f9e5d1
Compare
greatertomi
changed the title
greatertomi
force-pushed
the
fix/lw-11927-collateral-issue
branch
from
9f9e5d1 to
9fab585
Compare
vetalcore
requested changes
Dec 6, 2024
greatertomi
force-pushed
the
fix/lw-11927-collateral-issue
branch
from
9fab585 to
f53d85d
Compare
|
vetalcore
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Proposed solution
Instead of using maxAda value, build a transaction with only the collateral. If the transaction succeed, the wallet has enough ada for collateral.