Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove the staking portfolio persistence modal #1572

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

greatertomi
Copy link
Contributor

@greatertomi greatertomi commented Dec 3, 2024

Checklist

  • JIRA - LW-11897
  • Proper tests implemented
  • Screenshots added.

Proposed solution

The staking portfolio persistence info modal causes the Multi-delegation modal to close untimely. Since that modal is no longer necessary, removing it solves the issue with the multi-delegation modal.

@greatertomi greatertomi requested a review from a team as a code owner December 3, 2024 13:36
@greatertomi greatertomi changed the title feat: remove the staking portfolio persistence modal fix: remove the staking portfolio persistence modal Dec 3, 2024
@pczeglik-iohk
Copy link
Contributor

pczeglik-iohk commented Dec 3, 2024

Allure Report

allure-report-publisher generated test report!

processReports: ✅ test report for c5d0be79

passed failed skipped flaky total result
Total 32 0 4 0 36

@greatertomi greatertomi force-pushed the fix/lw-11897-remove-portfolio-persistence-modal branch from 7ccfdee to 6ab056f Compare December 3, 2024 14:17
Copy link

sonarqubecloud bot commented Dec 4, 2024

@greatertomi greatertomi merged commit fef43f5 into main Dec 10, 2024
49 of 51 checks passed
@greatertomi greatertomi deleted the fix/lw-11897-remove-portfolio-persistence-modal branch December 10, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants