Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [lw-11876]: upgrade to lace in send flow if locked rewards available #1570

Merged
merged 5 commits into from
Dec 10, 2024

Conversation

vetalcore
Copy link
Contributor

@vetalcore vetalcore commented Dec 2, 2024

Checklist

  • JIRA - LW-11876
  • Proper tests implemented
  • Screenshots added.

Proposed solution

Explain how does this PR solves the problem stated in JIRA ticket.
You can also enumerate different alternatives considered while approaching this task.

Testing

Describe here, how the new implementation can be tested.
Provide link or briefly describe User Acceptance Criteria/Tests that need to be met

Screenshots

Screenshot 2024-12-02 at 12 08 11

@vetalcore vetalcore requested a review from mchappell December 2, 2024 10:09
@vetalcore vetalcore self-assigned this Dec 2, 2024
@vetalcore vetalcore requested a review from a team as a code owner December 2, 2024 10:09
@pczeglik-iohk
Copy link
Contributor

pczeglik-iohk commented Dec 2, 2024

Allure Report

allure-report-publisher generated test report!

processReports: ✅ test report for 3fbc1f28

passed failed skipped flaky total result
Total 32 0 4 0 36

@vetalcore vetalcore force-pushed the feat/lw-11876-upgrade-to-lace-from-send-flow branch from 5207494 to 0a17872 Compare December 2, 2024 13:39
@vetalcore vetalcore changed the title fix: [lw-11876]: upgrade to lace in send flow in locked rewards available fix: [lw-11876]: upgrade to lace in send flow if locked rewards available Dec 2, 2024
@vetalcore vetalcore force-pushed the feat/lw-11876-upgrade-to-lace-from-send-flow branch 2 times, most recently from 4134727 to ae68ca6 Compare December 4, 2024 13:50
Copy link
Contributor

@mirceahasegan mirceahasegan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @vetalcore !

@vetalcore vetalcore force-pushed the feat/lw-11876-upgrade-to-lace-from-send-flow branch from ae68ca6 to a8eabd2 Compare December 6, 2024 23:29
Copy link

sonarcloud bot commented Dec 6, 2024

@ljagiela ljagiela merged commit 6b276dc into main Dec 10, 2024
30 of 31 checks passed
@ljagiela ljagiela deleted the feat/lw-11876-upgrade-to-lace-from-send-flow branch December 10, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants