Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [lw-11877]: force Nami-mode users to switch to Lace delegating from dapp popup #1559

Merged
merged 10 commits into from
Dec 11, 2024

Conversation

vetalcore
Copy link
Contributor

@vetalcore vetalcore commented Nov 22, 2024

Checklist

  • JIRA - LW-11877
  • Proper tests implemented
  • Screenshots added.

Proposed solution

Explain how does this PR solves the problem stated in JIRA ticket.
You can also enumerate different alternatives considered while approaching this task.

Testing

Describe here, how the new implementation can be tested.
Provide link or briefly describe User Acceptance Criteria/Tests that need to be met

Screenshots

Screenshot 2024-11-22 at 19 40 22

@vetalcore vetalcore self-assigned this Nov 22, 2024
@vetalcore vetalcore requested a review from a team as a code owner November 22, 2024 18:16
@pczeglik-iohk
Copy link
Contributor

pczeglik-iohk commented Nov 22, 2024

Allure Report

allure-report-publisher generated test report!

processReports: ✅ test report for ca2ea8f6

passed failed skipped flaky total result
Total 32 0 4 0 36

@vetalcore vetalcore force-pushed the feat/lw-11877-switch-to-lace-from-dapp-popup branch 2 times, most recently from d53140c to 46fd36e Compare November 27, 2024 19:38
Copy link
Contributor

@mirceahasegan mirceahasegan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @vetalcore 🥇

@vetalcore vetalcore force-pushed the feat/lw-11877-switch-to-lace-from-dapp-popup branch from 43794a8 to 31a2de8 Compare December 4, 2024 13:46
@vetalcore vetalcore force-pushed the feat/lw-11877-switch-to-lace-from-dapp-popup branch from 31a2de8 to cd2fe9e Compare December 4, 2024 13:57
@mirceahasegan mirceahasegan merged commit eaa7240 into main Dec 11, 2024
30 of 31 checks passed
@mirceahasegan mirceahasegan deleted the feat/lw-11877-switch-to-lace-from-dapp-popup branch December 11, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants