-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [lw-11877]: force Nami-mode users to switch to Lace delegating from dapp popup #1559
Merged
mirceahasegan
merged 10 commits into
main
from
feat/lw-11877-switch-to-lace-from-dapp-popup
Dec 11, 2024
Merged
fix: [lw-11877]: force Nami-mode users to switch to Lace delegating from dapp popup #1559
mirceahasegan
merged 10 commits into
main
from
feat/lw-11877-switch-to-lace-from-dapp-popup
Dec 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allure Report
processReports: ✅ test report for ca2ea8f6
|
apps/browser-extension-wallet/src/views/nami-mode/NamiDappConnectorView.tsx
Outdated
Show resolved
Hide resolved
vetalcore
force-pushed
the
feat/lw-11877-switch-to-lace-from-dapp-popup
branch
2 times, most recently
from
November 27, 2024 19:38
d53140c
to
46fd36e
Compare
mirceahasegan
approved these changes
Nov 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @vetalcore 🥇
vetalcore
force-pushed
the
feat/lw-11877-switch-to-lace-from-dapp-popup
branch
from
December 4, 2024 13:46
43794a8
to
31a2de8
Compare
vetalcore
force-pushed
the
feat/lw-11877-switch-to-lace-from-dapp-popup
branch
from
December 4, 2024 13:57
31a2de8
to
cd2fe9e
Compare
Quality Gate passedIssues Measures |
mirceahasegan
deleted the
feat/lw-11877-switch-to-lace-from-dapp-popup
branch
December 11, 2024 09:10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Proposed solution
Explain how does this PR solves the problem stated in JIRA ticket.
You can also enumerate different alternatives considered while approaching this task.
Testing
Describe here, how the new implementation can be tested.
Provide link or briefly describe User Acceptance Criteria/Tests that need to be met
Screenshots