Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [LW-11855] #1552

Merged
merged 20 commits into from
Dec 6, 2024
Merged

fix: [LW-11855] #1552

merged 20 commits into from
Dec 6, 2024

Conversation

mchappell
Copy link
Collaborator

@mchappell mchappell commented Nov 21, 2024

@mchappell mchappell requested a review from a team as a code owner November 21, 2024 09:52
@pczeglik-iohk
Copy link
Contributor

pczeglik-iohk commented Nov 21, 2024

Allure Report

allure-report-publisher generated test report!

processReports: ✅ test report for 74c74916

passed failed skipped flaky total result
Total 32 0 4 0 36

Copy link
Member

@mkazlauskas mkazlauskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good, nice work! 🚀

Disclaimer: only reviewed code changes, didn't test

Copy link
Contributor

@przemyslaw-wlodek przemyslaw-wlodek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ 👏🏻 Thank you @mchappell!

Copy link

sonarqubecloud bot commented Dec 5, 2024

@mchappell mchappell merged commit 6f838b9 into main Dec 6, 2024
30 of 31 checks passed
@mchappell mchappell deleted the fix/lw-11855 branch December 6, 2024 10:00
ljagiela pushed a commit that referenced this pull request Dec 6, 2024
* fix: lw-11855
* feat(nami): add dedicated password component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants