feat(ui,core,staking): [LW-9594] refactor Select component + design updates #1109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allure Report
smokeTests: ✅ test report for 91df40e6
|
vetalcore
reviewed
May 1, 2024
...s/staking/src/features/BrowsePools/BrowsePoolsPreferencesCard/BrowsePoolsPreferencesCard.tsx
Show resolved
Hide resolved
…teractions" This reverts commit 775ea2f.
mchappell
previously requested changes
May 3, 2024
packages/ui/src/design-system/decorators/page-provider.component.tsx
Outdated
Show resolved
Hide resolved
packages/ui/src/design-system/select/select-item/select-item-root.component.css.ts
Outdated
Show resolved
Hide resolved
vetalcore
approved these changes
May 7, 2024
vetalcore
reviewed
May 7, 2024
packages/ui/src/design-system/decorators/page-section.component.tsx
Outdated
Show resolved
Hide resolved
packages/ui/src/design-system/select/select-item/select-item-root.component.tsx
Show resolved
Hide resolved
|
Nicely done, @przemyslaw-wlodek.
it could have really helped with the review and delivery. |
|
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Proposed solution
This PR is introducing a new design and API of the Select component. We aim to make it as flexible as possible, which is the first step.
Testing
Please test the existing usage of the component:
WalletSetupSelectAccountsStepRevamp(Revamped Wallet setup flow)QuorumOption(Shared wallet feature)BrowsePoolsPreferencesCard(Staking - Browse Pools; Enabled with feature flagUSE_MULTI_DELEGATION_STAKING_FILTERS; it may be refactored during "advanced filters" ticket)Screenshots