Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: input field overlap #1095

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Conversation

greatertomi
Copy link
Contributor

@greatertomi greatertomi commented Apr 23, 2024

Checklist

  • JIRA - LW-10298
  • Proper tests implemented
  • Screenshots added.

Proposed solution

Fix input fields overlap

Testing

Describe here, how the new implementation can be tested.
Provide link or briefly describe User Acceptance Criteria/Tests that need to be met

Screenshots

Screenshot 2024-04-23 at 16 40 05

@greatertomi greatertomi requested a review from a team as a code owner April 23, 2024 15:44
Copy link

sonarcloud bot commented Apr 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Allure report

allure-report-publisher generated test report!

smokeTests: ✅ test report for 6302aa58

passed failed skipped flaky total result
Total 27 0 0 0 27

Copy link
Contributor

@emiride emiride left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on discussions between dev and product. It is decided that issue will be fixed so that dropdown does take whole screen, but will look nicer and not overlap with underlaying text.
Tested and it works as discussion concluded.
https://input-output-rnd.slack.com/archives/C055KJDMGUF/p1714470908175969

@greatertomi greatertomi merged commit 7ffd2f2 into main Apr 30, 2024
12 checks passed
@greatertomi greatertomi deleted the fix/lw-10259-input-field-overlap branch April 30, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants