Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(staking): [LW-10282] staking storybook build #1072

Merged

Conversation

mchappell
Copy link
Collaborator

@mchappell mchappell commented Apr 16, 2024

Checklist

  • JIRA - LW-10282
  • Proper tests implemented
  • Screenshots added.

Proposed solution

Explain how does this PR solves the problem stated in JIRA ticket.
You can also enumerate different alternatives considered while approaching this task.

Testing

Describe here, how the new implementation can be tested.
Provide link or briefly describe User Acceptance Criteria/Tests that need to be met

Screenshots

Attach screenshots here if implementation involves some UI changes

@mchappell mchappell requested a review from a team as a code owner April 16, 2024 10:15
Copy link
Contributor

@pczeglik-iohk pczeglik-iohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Nice catch @mchappell 👏

Thank you for fixing this issue.

@mchappell mchappell enabled auto-merge (squash) April 16, 2024 10:38
Copy link

github-actions bot commented Apr 16, 2024

Allure report

allure-report-publisher generated test report!

smokeTests: ✅ test report for 9faad9a9

passed failed skipped flaky total result
Total 27 0 0 0 27

@mchappell mchappell force-pushed the fix/lw-10282-fix-staking-storybook-build-and-chromatic branch from f3561f7 to 9faad9a Compare April 19, 2024 12:32
Copy link

sonarcloud bot commented Apr 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mchappell mchappell merged commit f32d2a1 into main Apr 19, 2024
13 checks passed
@mchappell mchappell deleted the fix/lw-10282-fix-staking-storybook-build-and-chromatic branch April 19, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants